Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment information to pov-project.json metadata #25

Closed
2 tasks done
wtwhite opened this issue Sep 27, 2023 · 2 comments
Closed
2 tasks done

Add environment information to pov-project.json metadata #25

wtwhite opened this issue Sep 27, 2023 · 2 comments
Assignees

Comments

@wtwhite
Copy link
Collaborator

wtwhite commented Sep 27, 2023

Some PoVs (at least CVE-2016-2510, CVE-2015-6420 and CVE-2015-7501) require particular environment variables to be set, especially the JDK to use in JAVA_HOME or they won't work (e.g., tests will be skipped). This information should be tracked in the pov-project.json metadata for each PoV, so that it can be automatically applied by shadedetector without having to remember the right -env command-line parameter.

  • Add element to schema
  • Add info to relevant CVEs' pov-project.json files

Some relevant info (commands with -env parameters) in https://github.com/jensdietrich/shadedetector/blob/main/scripts.zip.

This is an extension of #24.

@wtwhite wtwhite self-assigned this Sep 27, 2023
@wtwhite
Copy link
Collaborator Author

wtwhite commented Sep 27, 2023

Ideally we want to make some environment variables, like JAVA_HOME for setting the JDK to use, configurable at a higher level so that they work across different environments. E.g., to run on JDK 8, the run-on-java8.properties inside scripts.zip specifies

JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_311.jdk/Contents/Home

while I need

JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk-amd64

on my Linux VM.

@wtwhite
Copy link
Collaborator Author

wtwhite commented Sep 28, 2023

Resolved by adding jdkVersion to the Cue schema for pov-project.json, and by adding values for it, in #29 + #30 + #31.

@wtwhite wtwhite closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant