From c9643d317bcce94988365dad01dbbb7b93082a61 Mon Sep 17 00:00:00 2001 From: Severin Gehwolf Date: Thu, 12 Dec 2024 10:40:29 +0100 Subject: [PATCH] Naming fixes --- .../classes/jdk/tools/jlink/internal/JlinkTask.java | 10 +++++----- test/jdk/tools/jlink/IntegrationTest.java | 5 ++++- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java index 34a53e1df4ca5..6717d5517d1c5 100644 --- a/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java +++ b/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java @@ -412,14 +412,14 @@ private JlinkConfiguration initJlinkConfig() throws BadArgs { // Sanity check version if we use JMODs if (!isLinkFromRuntime) { - checkVersion(finder); + checkJavaBaseVersion(finder); } // Determine the roots set Set roots = new HashSet<>(); for (String mod : options.addMods) { if (mod.equals(ALL_MODULE_PATH)) { - ModuleFinder mf = limitFinder(finder, options.limitMods, + ModuleFinder mf = newLimitedFinder(finder, options.limitMods, Set.of()); mf.findAll() .stream() @@ -430,7 +430,7 @@ private JlinkConfiguration initJlinkConfig() throws BadArgs { roots.add(mod); } } - finder = limitFinder(finder, options.limitMods, roots); + finder = newLimitedFinder(finder, options.limitMods, roots); // --keep-packaged-modules doesn't make sense as we are not linking // from packaged modules to begin with. @@ -497,7 +497,7 @@ public static Path getDefaultModulePath() { * specified in {@code limitMods} plus other modules specified in the * {@code roots} set. */ - public static ModuleFinder limitFinder(ModuleFinder finder, + public static ModuleFinder newLimitedFinder(ModuleFinder finder, Set limitMods, Set roots) { // if limitMods is specified then limit the universe @@ -548,7 +548,7 @@ public Set findAll() { * version or the java.base version is not the same as the current runtime's * version. */ - private static void checkVersion(ModuleFinder finder) { + private static void checkJavaBaseVersion(ModuleFinder finder) { assert finder.find("java.base").isPresent(); // use the version of java.base module, if present, as diff --git a/test/jdk/tools/jlink/IntegrationTest.java b/test/jdk/tools/jlink/IntegrationTest.java index 883662ce13a42..7f3dc22346106 100644 --- a/test/jdk/tools/jlink/IntegrationTest.java +++ b/test/jdk/tools/jlink/IntegrationTest.java @@ -157,7 +157,10 @@ private static void test() throws Exception { boolean linkFromRuntime = false; JlinkConfiguration config = new Jlink.JlinkConfiguration(output, mods, - JlinkTask.limitFinder(JlinkTask.newModuleFinder(modulePaths), limits, mods), linkFromRuntime, false, false); + JlinkTask.newLimitedFinder(JlinkTask.newModuleFinder(modulePaths), limits, mods), + linkFromRuntime, + false /* ignore modified runtime */, + false /* generate run-time image */); List lst = new ArrayList<>();