Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buy/sell events to Farmer's Log #478

Open
tim-phillips opened this issue Jan 26, 2024 · 8 comments
Open

Add buy/sell events to Farmer's Log #478

tim-phillips opened this issue Jan 26, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@tim-phillips
Copy link
Contributor

I found that I wanted to reference past buys and sales when strategizing my purchases.

@tim-phillips
Copy link
Contributor Author

I'm going to keep playing to see if the Crop Price Guide solves this.

@jeremyckahn
Copy link
Owner

I think this is a great idea! I've added it to the backlog. 🙂

@jeremyckahn
Copy link
Owner

I'm going to keep playing to see if the Crop Price Guide solves this.

It won't. The Crop Price Guide is an indicator near each item's price that shows whether it is a good or a bad buy:

Crop Price Guide screenshot

@jeremyckahn jeremyckahn added the enhancement New feature or request label Jan 26, 2024
@jeremyckahn
Copy link
Owner

Actually it looks like this functionality is already implemented:

Farmer's log screenshot

I must have added it so long ago that I forgot. 😅

@tim-phillips Are you not seeing price events like this in your Farmer's Log?

@tim-phillips
Copy link
Contributor Author

I am seeing those, but I was thinking of adding events such as "You purchased 20 carrot seeds at $8.32 each" or "You sold 8 Grade A Rainbow Milks at $60 each".

@jeremyckahn
Copy link
Owner

I am seeing those, but I was thinking of adding events such as "You purchased 20 carrot seeds at $8.32 each" or "You sold 8 Grade A Rainbow Milks at $60 each".

I see. That could be a useful addition! If we do this, it would be worth merging redundant notifications because a lot of players tend to just spam the "sell" and "buy" buttons rather than doing bulk operations. There's no prior art for that sort of thing in the codebase currently.

I don't think I'll be getting to this in the near future, but I'd be happy to support a PR to get it done!

@tim-phillips
Copy link
Contributor Author

Ah, I hadn't considered spamming, that might make things a bit complicated. Maybe the events could be batched by day for each type of item.

@jeremyckahn
Copy link
Owner

Maybe the events could be batched by day for each type of item.

I think that would be a good way to handle it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants