Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance_model isn't checked before using #42

Open
jerry871002 opened this issue Aug 9, 2023 · 0 comments
Open

performance_model isn't checked before using #42

jerry871002 opened this issue Aug 9, 2023 · 0 comments
Labels
bug Something isn't working low priority This is not urgent at the moment

Comments

@jerry871002
Copy link
Owner

To pass the mypy type check, I initialized performance_model as None (see the examples below).

https://github.com/jerry871002/bayesian-strategy-inference/blob/e71229871278286cf72590ea3bff5508886092fa/src/grid_world/agent.py#L29

https://github.com/jerry871002/bayesian-strategy-inference/blob/e71229871278286cf72590ea3bff5508886092fa/src/navigation_game/agent.py#L27

https://github.com/jerry871002/bayesian-strategy-inference/blob/e71229871278286cf72590ea3bff5508886092fa/src/soccer_game/agent.py#L29

But I didn't add any check before using it to ensure the value is properly set, e.g. is it properly set to an array-like value and not None. Need to fix this in the future.

@jerry871002 jerry871002 added bug Something isn't working low priority This is not urgent at the moment labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority This is not urgent at the moment
Projects
None yet
Development

No branches or pull requests

1 participant