From 27cf41254770398efb866b2edbfc46304e5edfe4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jerry=20J=C3=A4ppinen?= Date: Sun, 1 Oct 2023 22:41:10 +0200 Subject: [PATCH] Comments --- scss/variables/colors.scss | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scss/variables/colors.scss b/scss/variables/colors.scss index 4732036..7d223dd 100644 --- a/scss/variables/colors.scss +++ b/scss/variables/colors.scss @@ -1,4 +1,5 @@ // FIXME: should maybe be moved to sub sections +// FIXME: add --dark and --light variants that are NOT flipped per theme :root { // Color usage @@ -18,12 +19,15 @@ // Color usage in inverted elements (e.g. buttons and containers) // NOTE: this is NOT for dark mode - // NOTE: for dark mode support, you should update flip these variables also + // NOTE: for dark mode support, you should flip these variables also --inverted-text-color: var(--very-very-very-faint-neutral, #fff); --inverted-border-color: var(--strong-neutral, #444); --inverted-background-color: var(--very-very-strong-neutral, #111); --inverted-offset-background-color: var(--very-strong-neutral, #333); + // NOTE: why are these commented out? Should we have these defined by default or rather not? + // NOTE: we can also update --text-color using CSS locally + // --inverted-discreet-color: var(--discreet-color); // --inverted-faint-discreet-color: var(--faint-discreet-color); // --inverted-very-faint-discreet-color: var(--very-faint-discreet-color);