Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToDo] Throw errors for invalid root nodes #15

Open
matthew-dean opened this issue Jan 24, 2021 · 1 comment
Open

[ToDo] Throw errors for invalid root nodes #15

matthew-dean opened this issue Jan 24, 2021 · 1 comment
Labels
enhancement New feature or request todo

Comments

@matthew-dean
Copy link
Member

Right now, if you do something like:

@include borders();

If the return value is another call (instead of a result of a call), then it dumps the call as-is. We should make sure that that can't happen. Could just as simple a matter of checking the value of @include after evaluation. 🤔

@matthew-dean matthew-dean added bug Something isn't working todo labels Jan 24, 2021
matthew-dean added a commit that referenced this issue Jan 25, 2021
@matthew-dean
Copy link
Member Author

Doesn't check final "root" nodes, but added error handling to the @include eval

@matthew-dean matthew-dean added enhancement New feature or request and removed bug Something isn't working labels Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request todo
Projects
None yet
Development

No branches or pull requests

1 participant