Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #1

Open
SimenB opened this issue Nov 10, 2019 · 2 comments
Open

Add tests #1

SimenB opened this issue Nov 10, 2019 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@SimenB
Copy link
Member

SimenB commented Nov 10, 2019

We should have a bunch of tests. There is https://github.com/vadimdemedes/ink-testing-library, but vadimdemedes/ink-testing-library#3 is an issue. We might wanna do some integration tests spawning up Jest and running tests, similar to how https://github.com/jest-community/jest-runner-eslint does it
@SimenB SimenB added the help wanted Extra attention is needed label Nov 10, 2019
@rchandu
Copy link

rchandu commented Apr 23, 2020

I would be interested. This would be first time I'd be contributing to OSS though. DO you suppose this would be a good beginner friendly issue ?

@SimenB
Copy link
Member Author

SimenB commented Apr 23, 2020

Hey @rchandu, thanks for reaching out! I haven't been able to spend the time to bootstrap any tests here, so in its current state it's not very beginner friendly, unfortunately... Thanks for offering though, I'll ping you whenever I get back to this project 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimenB @rchandu