Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Streamline codebase #30

Open
4 of 7 tasks
j-riebe opened this issue Apr 16, 2022 · 2 comments
Open
4 of 7 tasks

[REFACTOR] Streamline codebase #30

j-riebe opened this issue Apr 16, 2022 · 2 comments

Comments

@j-riebe
Copy link
Contributor

j-riebe commented Apr 16, 2022

Currenty, it's pretty hard to guess how the internal structure works.
This is mainly due to the "superfunction" that generates each plugin code and the missing abstractions inside (which lead to a lot of duplication).

@j-riebe
Copy link
Contributor Author

j-riebe commented Apr 16, 2022

I would offer to submit one/some PR(s) to tackle this problem.

The first is #29 (ClassRegistry).

I'm currently working on adding abstractions to the Plugin Logic.
@jhnnsrs you can keep track of it here.

@jhnnsrs
Copy link
Owner

jhnnsrs commented Apr 16, 2022

Great stuff! Theres really a need for a set of fresh eyes on this.

Some ideas:

From my perspective the schema driven generators (enums, inputs, objects) share a lot of common functionality and are pretty straightforward.

Fragments and Operations on the other hand are a bit messy as they generate classes on the fly during the recursion and handle some minor optimization (like not creating unnecessary zero-attribute classes).

Thanks a lot! I will be out for this weekend but happy to check it out start of next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants