Skip to content

Commit ccd88ae

Browse files
jhomlalajhomlala
authored
Feature/ios crash fix (#728)
* Fixed iOS crash issue on Swift 5.5 * Fixed iOS crash issue * Fixed iOS crash issue * Fixed iOS crash issue
1 parent c5c6b82 commit ccd88ae

File tree

8 files changed

+197
-11
lines changed

8 files changed

+197
-11
lines changed

‎CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
1+
## 0.0.76
2+
* Fixed iOS build issue.
3+
* [BREAKING_CHANGE] Changed min required iOS version to 11.
4+
15
## 0.0.75
2-
* Fixed iOS build issue connected with Swift 5.5.
6+
* Fixed iOS build issue.
37

48
## 0.0.74
59
* [BREAKING_CHANGE] `nextVideoTimeStreamController` is now marked as private. Please use `nextVideoTimeStream` to access stream.

‎docs/install.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
```yaml
66
dependencies:
7-
better_player: ^0.0.75
7+
better_player: ^0.0.76
88
```
99
1010
2. Install it

‎example/ios/Runner.xcodeproj/project.pbxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@
389389
"$(PROJECT_DIR)/Flutter",
390390
);
391391
INFOPLIST_FILE = Runner/Info.plist;
392-
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
392+
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
393393
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
394394
LIBRARY_SEARCH_PATHS = (
395395
"$(inherited)",
@@ -526,7 +526,7 @@
526526
"$(PROJECT_DIR)/Flutter",
527527
);
528528
INFOPLIST_FILE = Runner/Info.plist;
529-
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
529+
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
530530
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
531531
LIBRARY_SEARCH_PATHS = (
532532
"$(inherited)",
@@ -558,7 +558,7 @@
558558
"$(PROJECT_DIR)/Flutter",
559559
);
560560
INFOPLIST_FILE = Runner/Info.plist;
561-
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
561+
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
562562
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
563563
LIBRARY_SEARCH_PATHS = (
564564
"$(inherited)",

‎example/pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ dev_dependencies:
2222
flutter_test:
2323
sdk: flutter
2424

25-
2625
flutter:
2726
assets:
2827
- assets/

‎ios/Classes/CacheManager.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,10 @@ import PINCache
3030

3131
var server: HLSCachingReverseProxyServer?
3232

33-
lazy var storage: Cache.Storage? = {
34-
return try? Cache.Storage(diskConfig: diskConfig, memoryConfig: memoryConfig, transformer: TransformerFactory.forCodable(ofType: Data.self))
33+
lazy var storage: Cache.Storage<String,Data>? = {
34+
return try? Cache.Storage<String,Data>(diskConfig: diskConfig, memoryConfig: memoryConfig, transformer: TransformerFactory.forCodable(ofType: Data.self))
3535
}()
36+
3637

3738
///Setups cache server for HLS streams
3839
@objc public func setup(){

‎ios/better_player.podspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ A new flutter plugin project.
1515
s.source_files = 'Classes/**/*'
1616
s.public_header_files = 'Classes/**/*.h'
1717
s.dependency 'Flutter'
18-
s.dependency 'Cache'
18+
s.dependency 'Cache', '~> 6.0.0'
1919
s.dependency 'HLSCachingReverseProxyServer'
2020

21-
s.platform = :ios, '8.0'
21+
s.platform = :ios, '11.0'
2222
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' }
2323
end
2424

‎pubspec.lock

Lines changed: 182 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,27 @@ packages:
1515
url: "https://pub.dartlang.org"
1616
source: hosted
1717
version: "2.1.0"
18+
cached_network_image:
19+
dependency: transitive
20+
description:
21+
name: cached_network_image
22+
url: "https://pub.dartlang.org"
23+
source: hosted
24+
version: "3.1.0"
25+
cached_network_image_platform_interface:
26+
dependency: transitive
27+
description:
28+
name: cached_network_image_platform_interface
29+
url: "https://pub.dartlang.org"
30+
source: hosted
31+
version: "1.0.0"
32+
cached_network_image_web:
33+
dependency: transitive
34+
description:
35+
name: cached_network_image_web
36+
url: "https://pub.dartlang.org"
37+
source: hosted
38+
version: "1.0.1"
1839
characters:
1940
dependency: transitive
2041
description:
@@ -43,6 +64,13 @@ packages:
4364
url: "https://pub.dartlang.org"
4465
source: hosted
4566
version: "1.15.0"
67+
crypto:
68+
dependency: transitive
69+
description:
70+
name: crypto
71+
url: "https://pub.dartlang.org"
72+
source: hosted
73+
version: "3.0.1"
4674
csslib:
4775
dependency: transitive
4876
description:
@@ -83,6 +111,20 @@ packages:
83111
description: flutter
84112
source: sdk
85113
version: "0.0.0"
114+
flutter_blurhash:
115+
dependency: transitive
116+
description:
117+
name: flutter_blurhash
118+
url: "https://pub.dartlang.org"
119+
source: hosted
120+
version: "0.6.0"
121+
flutter_cache_manager:
122+
dependency: transitive
123+
description:
124+
name: flutter_cache_manager
125+
url: "https://pub.dartlang.org"
126+
source: hosted
127+
version: "3.1.2"
86128
flutter_localizations:
87129
dependency: "direct dev"
88130
description: flutter
@@ -112,6 +154,27 @@ packages:
112154
url: "https://pub.dartlang.org"
113155
source: hosted
114156
version: "0.15.0"
157+
html_unescape:
158+
dependency: transitive
159+
description:
160+
name: html_unescape
161+
url: "https://pub.dartlang.org"
162+
source: hosted
163+
version: "2.0.0"
164+
http:
165+
dependency: transitive
166+
description:
167+
name: http
168+
url: "https://pub.dartlang.org"
169+
source: hosted
170+
version: "0.13.3"
171+
http_parser:
172+
dependency: transitive
173+
description:
174+
name: http_parser
175+
url: "https://pub.dartlang.org"
176+
source: hosted
177+
version: "4.0.0"
115178
intl:
116179
dependency: transitive
117180
description:
@@ -147,6 +210,13 @@ packages:
147210
url: "https://pub.dartlang.org"
148211
source: hosted
149212
version: "1.7.0"
213+
octo_image:
214+
dependency: transitive
215+
description:
216+
name: octo_image
217+
url: "https://pub.dartlang.org"
218+
source: hosted
219+
version: "1.0.0+1"
150220
path:
151221
dependency: transitive
152222
description:
@@ -203,6 +273,13 @@ packages:
203273
url: "https://pub.dartlang.org"
204274
source: hosted
205275
version: "4.3.0"
276+
photo_view:
277+
dependency: transitive
278+
description:
279+
name: photo_view
280+
url: "https://pub.dartlang.org"
281+
source: hosted
282+
version: "0.11.1"
206283
platform:
207284
dependency: transitive
208285
description:
@@ -224,6 +301,13 @@ packages:
224301
url: "https://pub.dartlang.org"
225302
source: hosted
226303
version: "4.1.0"
304+
rxdart:
305+
dependency: transitive
306+
description:
307+
name: rxdart
308+
url: "https://pub.dartlang.org"
309+
source: hosted
310+
version: "0.27.2"
227311
sky_engine:
228312
dependency: transitive
229313
description: flutter
@@ -236,6 +320,20 @@ packages:
236320
url: "https://pub.dartlang.org"
237321
source: hosted
238322
version: "1.8.1"
323+
sqflite:
324+
dependency: transitive
325+
description:
326+
name: sqflite
327+
url: "https://pub.dartlang.org"
328+
source: hosted
329+
version: "2.0.0+4"
330+
sqflite_common:
331+
dependency: transitive
332+
description:
333+
name: sqflite_common
334+
url: "https://pub.dartlang.org"
335+
source: hosted
336+
version: "2.0.1+1"
239337
stack_trace:
240338
dependency: transitive
241339
description:
@@ -257,6 +355,13 @@ packages:
257355
url: "https://pub.dartlang.org"
258356
source: hosted
259357
version: "1.1.0"
358+
synchronized:
359+
dependency: transitive
360+
description:
361+
name: synchronized
362+
url: "https://pub.dartlang.org"
363+
source: hosted
364+
version: "3.0.0"
260365
term_glyph:
261366
dependency: transitive
262367
description:
@@ -271,20 +376,97 @@ packages:
271376
url: "https://pub.dartlang.org"
272377
source: hosted
273378
version: "0.4.2"
379+
tweet_ui:
380+
dependency: "direct main"
381+
description:
382+
name: tweet_ui
383+
url: "https://pub.dartlang.org"
384+
source: hosted
385+
version: "3.0.0"
274386
typed_data:
275387
dependency: transitive
276388
description:
277389
name: typed_data
278390
url: "https://pub.dartlang.org"
279391
source: hosted
280392
version: "1.3.0"
393+
url_launcher:
394+
dependency: transitive
395+
description:
396+
name: url_launcher
397+
url: "https://pub.dartlang.org"
398+
source: hosted
399+
version: "6.0.12"
400+
url_launcher_linux:
401+
dependency: transitive
402+
description:
403+
name: url_launcher_linux
404+
url: "https://pub.dartlang.org"
405+
source: hosted
406+
version: "2.0.2"
407+
url_launcher_macos:
408+
dependency: transitive
409+
description:
410+
name: url_launcher_macos
411+
url: "https://pub.dartlang.org"
412+
source: hosted
413+
version: "2.0.2"
414+
url_launcher_platform_interface:
415+
dependency: transitive
416+
description:
417+
name: url_launcher_platform_interface
418+
url: "https://pub.dartlang.org"
419+
source: hosted
420+
version: "2.0.4"
421+
url_launcher_web:
422+
dependency: transitive
423+
description:
424+
name: url_launcher_web
425+
url: "https://pub.dartlang.org"
426+
source: hosted
427+
version: "2.0.4"
428+
url_launcher_windows:
429+
dependency: transitive
430+
description:
431+
name: url_launcher_windows
432+
url: "https://pub.dartlang.org"
433+
source: hosted
434+
version: "2.0.2"
435+
uuid:
436+
dependency: transitive
437+
description:
438+
name: uuid
439+
url: "https://pub.dartlang.org"
440+
source: hosted
441+
version: "3.0.4"
281442
vector_math:
282443
dependency: transitive
283444
description:
284445
name: vector_math
285446
url: "https://pub.dartlang.org"
286447
source: hosted
287448
version: "2.1.0"
449+
video_player:
450+
dependency: transitive
451+
description:
452+
name: video_player
453+
url: "https://pub.dartlang.org"
454+
source: hosted
455+
version: "2.2.5"
456+
video_player_platform_interface:
457+
dependency: transitive
458+
description:
459+
name: video_player_platform_interface
460+
url: "https://pub.dartlang.org"
461+
source: hosted
462+
version: "4.2.0"
463+
video_player_web:
464+
dependency: transitive
465+
description:
466+
name: video_player_web
467+
url: "https://pub.dartlang.org"
468+
source: hosted
469+
version: "2.0.4"
288470
visibility_detector:
289471
dependency: "direct main"
290472
description:

‎pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: better_player
22
description: Advanced video player based on video_player and Chewie. It's solves many typical use cases and it's easy to run.
3-
version: 0.0.75
3+
version: 0.0.76
44
# Disabled because of warning from analyzer
55
# authors:
66
# - Jakub Homlala <jhomlala@gmail.com>

0 commit comments

Comments
 (0)