New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "CleanCode/ElseExpression" issue in rescalcapi.php #13

Open

jhuesser opened this issue Apr 21, 2017 · 0 comments

Labels

Owner

jhuesser commented Apr 21, 2017

The method setThirdColorValue uses an else expression. Else is never necessary and you can simplify the code to work without else.

https://codeclimate.com/github/jhuesser/ResistorCalculatorAPI/rescalcapi.php#issue_58f9bfc14b47c80001000020

jhuesser added bug enhancement and removed bug labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment