Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heavily dependant on a single activity #14

Open
yigitsezer opened this issue Aug 2, 2021 · 0 comments
Open

Heavily dependant on a single activity #14

yigitsezer opened this issue Aug 2, 2021 · 0 comments

Comments

@yigitsezer
Copy link

The customized WeekView and the app the author came up with works great, however I can't say the same thing for readibility.

The code for both view and the app is heavily dependant on a single activity which is 2000+ lines of code as of me writing this making it really difficult to adapt to my use case. I was hoping you could seperate different logical parts of the app in the MainActivity so one could find what they were looking for easily, instead of searching through that big file.

Also the Readme.md explains a "How set event information and minimum and maximum date of calendar", content is outdated and no such method in the explanation exists in the code.
I'm currently using the "day view" on one of my ongoing projects and my use case is completely different, I get date information from a service thus creating my own "custom event" models so adding a custom event looks something like this:

mWeekView.weekViewLoader = object: WeekViewLoader{
            override fun onLoad(periodIndex: Int): MutableList<out WeekViewEvent> {
                return if (periodIndex == 0) {
                    mutableListOf(WeekViewEvent(0, "TEST EVENT", 2021, 8, 2, 20, 0, 2021, 8, 2, 21, 0))
                } else {
                    mutableListOf()
                }
            }
            //...
        }

And oh, one last thing, it would be GREAT if you could convert to Kotlin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant