-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not handle HTTPS meeting URLs #509
Comments
How is the app launched, with the URL as a parameter? |
Same problem here. The URL is passed as an immediate parameter. The URI handler just does not support http links and will return if the string does not contain Line 274 in 77a203e
I use the flatpak but the test case to reproduce is simpler with the AppImage: Loads the meeting:
Loads the home page:
Fedora 34 |
This comment has been minimized.
This comment has been minimized.
Choosy is my app. The low-level mechanism for how Choosy sends URLs to applications is an Apple Event, but from the receiving app's perspective you don't need to worry too much about the events themselves as long as you do two things:
|
The same situation in WIndows with browsers. Jitsi-electron redirects the external authorization URL to the browser and after successful authorization the meeting opens in browser. |
We redirect using the custom URL scheme. Are you using the latest Electron app and connecting to meet.jit.si or is your setup different? |
Hi saghul, |
The redirection needs to happen in your auth app. For meet.jit.si we use Firebase auth for example, and there we redirect to the custom scheme, so the app opens. That is really not something this app can or should solve. |
saghul, thank you very much for explanation. |
If you redirect to jitsi-meet://your-domain.tld/your-meeting the Electron app should take over. |
Description:
If Jitsi-Meet is sent an https:// link it does not handle it appropriately.
Since the use of jitsi-meet:// protocol links is rare, I was trying to use another utility to detect and pass https://meet.jit.si/* links from any app to the Jitsi.meet app. This works to open the Jitsi Meet Electron app, but the app does nothing and does not open the meeting link, as it would if the protocol was jitsi-meet://.
Unfortunately, I'm not aware of a utility that can rewrite the link to use the protocol handler instead.
I do not believe this is an issue with the utility that detects and passes these links, since this approach works with other Electron apps.
Thanks for considering.
Steps to reproduce:
Expected behavior:
Jitsi Meet Electron app opens and navigates to the meeting named in the link.
Actual behavior:
Jitsi Meet Electron app opens but does nothing and does not navigate to the meeting named in the link.
Client information:
The text was updated successfully, but these errors were encountered: