Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approving Remote Control Request Hangs Application #877

Open
benkaiser opened this issue Jul 4, 2023 · 12 comments
Open

Approving Remote Control Request Hangs Application #877

benkaiser opened this issue Jul 4, 2023 · 12 comments
Labels
macOS Issues affecting macOS windows Issues affecting Windows

Comments

@benkaiser
Copy link

benkaiser commented Jul 4, 2023

Description

Accepting the dialog to allow remote control permissions hangs the entire application. Below is a screenshot of the application in it's stuck state.

image

Current behavior

App freezes.

Expected Behavior

App should continue to work, enabling remote control for requested user.

Possible Solution

I tried executing the electron instance with devtools opened, but trying to record a performance trace was stuck on the first initializing step, it was really stuck whatever it is that is causing it. The only thing to do is quit the application and re-open.

Steps to reproduce

  1. Run the electron client locally changing this line to true to enable remote control
  2. Run either with npm start or npm run dist (and then copy to Applications folder)

Environment details

MacOS Ventura 13.0.1

@benkaiser
Copy link
Author

I understand this is a disable feature / likely not officially supported. But would be great to get to the bottom of what broke this functionality.

@milaq
Copy link

milaq commented Jul 24, 2023

Same behavior on Windows with ENABLE_REMOTE_CONTROL = true;

@saghul
Copy link
Member

saghul commented Jul 24, 2023

We haven't found the time to look into this yet, sorry!

@csett86 csett86 added the macOS Issues affecting macOS label Jan 28, 2024
@ed76
Copy link

ed76 commented Apr 29, 2024

is there any news on this? does it work again with the current version?

@bilogic
Copy link

bilogic commented Oct 13, 2024

image

After building e64c8ac in Windows 10/11, this is a screenshot of the frozen application with a translucent dialog trying to fade out

@bilogic
Copy link

bilogic commented Oct 13, 2024

I propose renaming the title of this issue to Approving Remote Control Request Hangs Application

@csett86 csett86 added the windows Issues affecting Windows label Oct 13, 2024
@csett86 csett86 changed the title Approving Remote Control Request Hangs Application on MacOS Approving Remote Control Request Hangs Application Oct 13, 2024
@bilogic
Copy link

bilogic commented Oct 24, 2024

Any interest in funding someone to fix this?

@saghul
Copy link
Member

saghul commented Oct 24, 2024

@hristoterezov @horymury can either of you PTAL?

@bilogic
Copy link

bilogic commented Nov 18, 2024

anything?

@marclaporte
Copy link

Related: 0b88a78

@bilogic
Copy link

bilogic commented Nov 18, 2024

No, that is unrelated. Remote control was disabled by default.
This issue is about remote control being broken when enabled.

@saghul
Copy link
Member

saghul commented Nov 18, 2024

@hristoterezov @horymury Guys, can either of you PTAL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Issues affecting macOS windows Issues affecting Windows
Projects
None yet
Development

No branches or pull requests

8 participants
@saghul @benkaiser @milaq @bilogic @marclaporte @csett86 @ed76 and others