Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: 'v v' wipes wordlist #366

Closed
jkotlinski opened this issue Aug 31, 2021 · 11 comments · Fixed by #395
Closed

bug: 'v v' wipes wordlist #366

jkotlinski opened this issue Aug 31, 2021 · 11 comments · Fixed by #395
Labels

Comments

@jkotlinski
Copy link
Owner

Repro:

v v
:q 
words

What happens: words?

Expected: wordlist is printed

@jkotlinski jkotlinski added the bug label Aug 31, 2021
@jkotlinski jkotlinski added this to the v4.0.0 milestone Aug 31, 2021
@jkotlinski
Copy link
Owner Author

it's unclear how to solve this in a good way.

@Whammo
Copy link
Collaborator

Whammo commented Sep 1, 2021

Is it so large that it overwrites the wordlist?

@jkotlinski
Copy link
Owner Author

I suppose so.

@Whammo
Copy link
Collaborator

Whammo commented Sep 1, 2021

It might be tricky, but there has been a suggestion to move the wordlist to the 4K RAM under i/o.

@jkotlinski
Copy link
Owner Author

Related: #311

@Whammo
Copy link
Collaborator

Whammo commented Oct 13, 2021

Doesn't TOP! enable moving the wordlist out of the way?

@Whammo
Copy link
Collaborator

Whammo commented Oct 13, 2021

Yes it does.
$cbff TOP! v v

good stuff

@jkotlinski jkotlinski removed this from the v4.0.0 milestone Dec 29, 2021
@jkotlinski
Copy link
Owner Author

A good solution for this would be to rewrite "v" so that it does not use unbounded memory. However that is a pretty big undertaking.

@jkotlinski
Copy link
Owner Author

jkotlinski commented Jan 1, 2022

Actually! There is a solid way to solve this problem, without much work at all.

Before v actually loads a file, read the disk directory to see how big the file is (in blocks, each block holding 254 bytes). If the file is too big for the buffer, ABORT" too big".

@jkotlinski jkotlinski added this to the v4.0.0 milestone Jan 1, 2022
@jkotlinski
Copy link
Owner Author

#395

^ this seems to work. sadly, there's not room on the cartridge (yet)

@jkotlinski
Copy link
Owner Author

jkotlinski commented Jan 2, 2022

A related thing now. Editor text buffer sits very awkwardly. It starts at $7000, and gets squeezed between HERE (grows up) and LATEST (grows down).
Wouldn't it make sense to move it to $a000-$cbff ?

...of course, one would probably want to use $a000-$cbff for Other Things. But in that case, it's OK to not use the text editor?
Alternatively, one could limit text editor buffer to $a000-$bfff, keeping $c000-$cbff free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants