Skip to content

Commit 75c9291

Browse files
committed
Fix frozen string literal issue
To prepare for ruby 3.4.0 and making strings frozen by default, we add `+` operator to make the string mutable
1 parent 5094ae6 commit 75c9291

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

.github/workflows/run_tests.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313

1414
strategy:
1515
matrix:
16-
ruby-version: ['3.1', '3.0', '2.7']
16+
ruby-version: ['3.3', '3.1', '2.7']
1717

1818
steps:
1919
- uses: actions/checkout@v3
@@ -26,5 +26,4 @@ jobs:
2626
- name: Install PDFTK-Java
2727
run: sudo apt install -y pdftk-java
2828
- name: Run tests
29-
run: bundle exec rake
30-
29+
run: RUBYOPT='--enable-frozen-string-literal --debug-frozen-string-literal' bundle exec rake

lib/pdf_forms/data_format.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def initialize(data = {}, options = {})
1515

1616
# generate PDF content in this data format
1717
def to_pdf_data
18-
pdf_data = header
18+
pdf_data = +header
1919

2020
@data.each do |key, value|
2121
if Hash === value

lib/pdf_forms/fdf.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def encode_data(fdf)
3030

3131
# pp 559 https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/pdf_reference_archives/PDFReference.pdf
3232
def header
33-
header = "%FDF-1.2\n\n1 0 obj\n<<\n/FDF << /Fields 2 0 R"
33+
header = +"%FDF-1.2\n\n1 0 obj\n<<\n/FDF << /Fields 2 0 R"
3434

3535
# /F
3636
header << "/F (#{options[:file]})" if options[:file]
@@ -45,7 +45,7 @@ def header
4545

4646
# pp 561 https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/pdf_reference_archives/PDFReference.pdf
4747
def field(key, value)
48-
field = "<<"
48+
field = +"<<"
4949
field << "/T" + "(#{key})"
5050
field << "/V" + (Array === value ? "[#{value.map{ |v|"(#{quote(v)})" }.join}]" : "(#{quote(value)})")
5151
field << ">>\n"

lib/pdf_forms/pdftk_wrapper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def call_pdftk(*args)
106106
def cat(*args)
107107
in_files = []
108108
page_ranges = []
109-
file_handle = "A"
109+
file_handle = +"A"
110110
output = normalize_path args.pop
111111

112112
args.flatten.compact.each do |in_file|

0 commit comments

Comments
 (0)