Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "label" representation for tree nodes #10

Open
arcanefoam opened this issue May 19, 2017 · 2 comments
Open

Add "label" representation for tree nodes #10

arcanefoam opened this issue May 19, 2017 · 2 comments

Comments

@arcanefoam
Copy link
Contributor

In the ArtifactTree, using the Java ID of the nodes does not provide usefull information about the node. The Node Interface could define a mehthod "getTreeLabel", which by deafault (abstract base class) returns the Java ID, but the plugin could override. Probably the method just actually go in the ArtifactData so the plugins can provide custom implementations (plugins dont extend nodes).

@arcanefoam
Copy link
Contributor Author

arcanefoam commented May 19, 2017

This probably also applies to the ArtifactGraph. Maybe a shorter version of the tree label ca be used for the graph (we want to avoid long names to reduce clutter). Perhaps for the ArtifactGraph, depends on the capabilites of the drawing tool, change the shape/border color?
(On a side note the ArtifactGraph needs a lagend)

@meik99
Copy link
Contributor

meik99 commented Jun 15, 2023

It's a good idea for this method to be implemented in ArtifactData so that plugins can override the behaviour.
The name, however, should just be getLabel imo, since getTreeLabel would suggest the method is used in a GUI of which a plugin should not be aware of.

I will open a separate issue for an ArtifactGraph-Legend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants