Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ArtifactXXX hierarchy #11

Open
arcanefoam opened this issue May 29, 2017 · 1 comment
Open

Improve ArtifactXXX hierarchy #11

arcanefoam opened this issue May 29, 2017 · 1 comment

Comments

@arcanefoam
Copy link
Contributor

The ArtifactPlugin, ArtifacterReader, etc.., share some of the itnerface methods. For example all the intefaces define the public abstract String getPluginId();

Perhaps a common super interface could be provided: ArtifactHelper to contain the common functionality. That way, for example, it would be easier to document that the getPluginId(); needs to return the class name of the ArtifactPlugin implementation.

@meik99
Copy link
Contributor

meik99 commented Jun 15, 2023

It seems like this method could just be removed and the existing plugins refactored, since the plugin name is already defined when extending the ArtifactPlugin class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants