diff --git a/CHANGELOG.md b/CHANGELOG.md index 03acb6d..3c896b7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ -# nanoflann 1.5.5: UNRELEASED - - (none yet) +# nanoflann 1.5.5: Released Mar 12, 2024 + - Potentially more efficient scheduling of multi-thread index building ([PR #236](https://github.com/jlblancoc/nanoflann/pull/236)) + - Bump minimum required cmake version to 3.5 ([PR #230](https://github.com/jlblancoc/nanoflann/pull/230/)) # nanoflann 1.5.4: Released Jan 10, 2024 - Fix outdated NANOFLANN_VERSION macro in header file diff --git a/README.md b/README.md index 0ce7934..4d0c332 100644 --- a/README.md +++ b/README.md @@ -197,6 +197,8 @@ This parameter is really ignored in `nanoflann`, but was kept for backward compa This parameter determines the maximum number of threads that can be called concurrently during the construction of the KD tree. The default value is 1. When the parameter is set to 0, `nanoflann` automatically determines the number of threads to use. +See [this pull request](https://github.com/jlblancoc/nanoflann/pull/236) for some benchmarking showing that using the maximum number of threads is not always the most efficient approach. Do benchmarking on your data! + ----- ## 3. Performance diff --git a/include/nanoflann.hpp b/include/nanoflann.hpp index d3dff4e..08ea6bb 100644 --- a/include/nanoflann.hpp +++ b/include/nanoflann.hpp @@ -1246,8 +1246,8 @@ class KDTreeBaseClass BoundingBox left_bbox(bbox); left_bbox[cutfeat].high = cutval; - node->child1 = this->divideTreeConcurrent( - obj, left, left + idx, left_bbox, thread_count, mutex); + node->child1 = this->divideTreeConcurrent( + obj, left, left + idx, left_bbox, thread_count, mutex); if (right_future.valid()) {