Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent parameters for Composite models for single structures versus multiple structures #106

Open
ConnorPigg opened this issue Jul 26, 2019 · 2 comments
Assignees
Labels

Comments

@ConnorPigg
Copy link
Collaborator

Currently when a single structure model is passed to composite modelling, a "shortcut" is taken to simplify the resulting reported parameters. This complicates scripted analysis comparing the results between single structure and multistructure fitting results. Such comparisons are potentially common when fitting a tree structure such that the root results are different in naming convention when compared to the rest of the tree's models. This "shortcut" should likely be removed.

@ConnorPigg ConnorPigg self-assigned this Jul 26, 2019
@jmborr
Copy link
Owner

jmborr commented Jul 26, 2019

Currently when a single structure model is passed to composite modelling, a "shortcut" is taken to simplify the resulting reported parameters. This complicates scripted analysis comparing the results between single structure and multistructure fitting results. Such comparisons are potentially common when fitting a tree structure such that the root results are different in naming convention when compared to the rest of the tree's models. This "shortcut" should likely be removed.

Can you point out in the code where this "shortcut" take place?

@ConnorPigg
Copy link
Collaborator Author

idpflex/idpflex/bayes.py

Lines 236 to 237 in be0c8af

if len(property_groups) == 1:
return create_model(property_groups[0], use_tabulated=use_tabulated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants