From 086389232bb21f2e3eda56849da0d78e6b70574e Mon Sep 17 00:00:00 2001
From: Robbert van Ginkel <robbert@vanginkels.com>
Date: Sun, 4 Aug 2019 18:23:21 -0700
Subject: [PATCH] Fix source mode to not trigger go modules (#23)

Fixes https://github.com/jmhodges/bazel_gomock/issues/17. Investigating a bit, golang's module mode seems to trigger when using source mode with a fake  module file, resulting in downloading modules  while doing codegen. This can be avoided by prefixing the path passed  to `-source` with `$GOPATH`, so `go/packages` recognizes the source file as being in the GOPATH.

This also removes the `_go_tool_run_shell_stdout`, which  was only  called from one place. Seemed better to remove as compared having to pass the gopath around to prefix the source flag.
---
 gomock.bzl | 74 ++++++++++++++++++++++++++----------------------------
 1 file changed, 36 insertions(+), 38 deletions(-)

diff --git a/gomock.bzl b/gomock.bzl
index 20532cf..90e79c1 100644
--- a/gomock.bzl
+++ b/gomock.bzl
@@ -5,17 +5,46 @@ _MOCKGEN_TOOL = "@com_github_golang_mock//mockgen"
 _MOCKGEN_MODEL_LIB = "@com_github_golang_mock//mockgen/model:go_default_library"
 
 def _gomock_source_impl(ctx):
-    args = ["-source", ctx.file.source.path]
+    go_ctx = go_context(ctx)
+    gopath = "$(pwd)/" + ctx.var["BINDIR"] + "/" + ctx.attr.gopath_dep[GoPath].gopath
+
+    # passed in source needs to be in gopath to not trigger module mode
+    args = ["-source", gopath + "/" + ctx.file.source.path]
     if ctx.attr.package != "":
         args += ["-package", ctx.attr.package]
     args += [",".join(ctx.attr.interfaces)]
 
-    _go_tool_run_shell_stdout(
-        ctx = ctx,
-        cmd = ctx.file.mockgen_tool,
-        args = args,
-        extra_inputs = [ctx.file.source],
-        out = ctx.outputs.out,
+    inputs = (
+        ctx.attr.gopath_dep.files.to_list() +
+        go_ctx.sdk.headers + go_ctx.sdk.srcs + go_ctx.sdk.tools
+    ) + [ctx.file.source]
+
+    # We can use the go binary from the stdlib for most of the environment
+    # variables, but our GOPATH is specific to the library target we were given.
+    ctx.actions.run_shell(
+        outputs = [ctx.outputs.out],
+        inputs = inputs,
+        tools = [
+            ctx.file.mockgen_tool,
+            go_ctx.go,
+        ],
+        command = """
+           source <($PWD/{godir}/go env) &&
+           export PATH=$GOROOT/bin:$PWD/{godir}:$PATH &&
+           export GOPATH={gopath} &&
+           mkdir -p .gocache &&
+           export GOCACHE=$PWD/.gocache &&
+           {cmd} {args} > {out}
+        """.format(
+            godir = go_ctx.go.path[:-1 - len(go_ctx.go.basename)],
+            gopath = gopath,
+            cmd = "$(pwd)/" + ctx.file.mockgen_tool.path,
+            args = " ".join(args),
+            out = ctx.outputs.out.path,
+        ),
+        env = {
+            "GO111MODULE": "off",  # explicitly relying on passed in go_path to not download modules while doing codegen
+        },
     )
 
 _gomock_source = go_rule(
@@ -241,34 +270,3 @@ _gomock_prog_exec = go_rule(
     },
 )
 
-def _go_tool_run_shell_stdout(ctx, cmd, args, extra_inputs, out):
-    go_ctx = go_context(ctx)
-    gopath = "$(pwd)/" + ctx.var["BINDIR"] + "/" + ctx.attr.gopath_dep[GoPath].gopath
-
-    inputs = (
-        ctx.attr.gopath_dep.files.to_list() +
-        go_ctx.sdk.headers + go_ctx.sdk.srcs + go_ctx.sdk.tools
-    ) + extra_inputs
-
-    # We can use the go binary from the stdlib for most of the environment
-    # variables, but our GOPATH is specific to the library target we were given.
-    ctx.actions.run_shell(
-        outputs = [out],
-        inputs = inputs,
-        tools = [
-            cmd,
-            go_ctx.go,
-        ],
-        command = """
-           source <($PWD/{godir}/go env) &&
-           export PATH=$GOROOT/bin:$PWD/{godir}:$PATH &&
-           export GOPATH={gopath} &&
-           {cmd} {args} > {out}
-        """.format(
-            godir = go_ctx.go.path[:-1 - len(go_ctx.go.basename)],
-            gopath = gopath,
-            cmd = "$(pwd)/" + cmd.path,
-            args = " ".join(args),
-            out = out.path,
-        ),
-    )