Add minor logger for error logging

joacand · joacand · commit 35ed76441bdf · 2021-01-03T00:39:03.000+01:00
diff --git a/VattenMedia.Core/Interfaces/ILogger.cs b/VattenMedia.Core/Interfaces/ILogger.cs
@@ -0,0 +1,9 @@
+﻿using VattenMedia.Core.Entities;
+
+namespace VattenMedia.Core.Interfaces
+{
+    public interface ILogger
+    {
+        void LogError(string message);
+    }
+}
diff --git a/VattenMedia.Core/Interfaces/IStatusTextService.cs b/VattenMedia.Core/Interfaces/IStatusTextService.cs
@@ -4,7 +4,7 @@ namespace VattenMedia.Core.Interfaces
 {
     public interface IStatusTextService
     {
-        void SetCallback(Action<string, TimeSpan?> changeStatus);
-        void ChangeStatusText(string status, TimeSpan? time = null);
+        void SetCallback(Action<string, TimeSpan?, bool> changeStatus);
+        void ChangeStatusText(string status, TimeSpan? time = null, bool isError = false);
     }
 }
diff --git a/VattenMedia.Infrastructure/Extensions/ContainerExtensions.cs b/VattenMedia.Infrastructure/Extensions/ContainerExtensions.cs
@@ -16,6 +16,7 @@ public static void AddInfrastructureRegistrations(this IUnityContainer container
             container.RegisterType<ITwitchService, TwitchService>();
             container.RegisterType<IYoutubeService, YoutubeService>();
             container.RegisterType<ITwitchChatClientFactory, TwitchChatClientFactory>();
+            container.RegisterType<ILogger, Logger>();
         }
     }
 }
diff --git a/VattenMedia.Infrastructure/Services/Logger.cs b/VattenMedia.Infrastructure/Services/Logger.cs
@@ -0,0 +1,31 @@
+﻿using System;
+using System.IO;
+using VattenMedia.Core.Interfaces;
+
+namespace VattenMedia.Infrastructure.Services
+{
+    public class Logger : ILogger
+    {
+        private string LogFileTodayDate => Path.Combine(AppDomain.CurrentDomain.BaseDirectory, DateTime.Now.ToShortDateString() + ".log");
+
+        public void LogError(string message)
+        {
+            var logFile = GetLogFile();
+
+            using StreamWriter sw = File.AppendText(logFile);
+            sw.WriteLine($"{DateTime.Now} - Error: {message}");
+        }
+
+        private string GetLogFile()
+        {
+            var logFile = LogFileTodayDate;
+
+            if (!File.Exists(logFile))
+            {
+                using (File.Create(logFile)) { };
+            }
+
+            return logFile;
+        }
+    }
+}
diff --git a/VattenMedia.Infrastructure/Services/StatusTextService.cs b/VattenMedia.Infrastructure/Services/StatusTextService.cs
@@ -5,20 +5,20 @@ namespace VattenMedia.Infrastructure.Services
 {
     internal class StatusTextService : IStatusTextService
     {
-        private Action<string, TimeSpan?> changeStatus;
+        private Action<string, TimeSpan?, bool> changeStatus;
 
         public StatusTextService()
         {
         }
 
-        public void SetCallback(Action<string, TimeSpan?> changeStatus)
+        public void SetCallback(Action<string, TimeSpan?, bool> changeStatus)
         {
-             this.changeStatus = changeStatus;
+            this.changeStatus = changeStatus;
         }
 
-        public void ChangeStatusText(string status, TimeSpan? time = null)
+        public void ChangeStatusText(string status, TimeSpan? time = null, bool isError = false)
         {
-            changeStatus(status, time);
+            changeStatus(status, time, isError);
         }
     }
 }
diff --git a/VattenMedia.Infrastructure/Services/StreamStarterService.cs b/VattenMedia.Infrastructure/Services/StreamStarterService.cs
@@ -10,13 +10,18 @@ internal class StreamStarterService : IStreamStarterService
     {
         private readonly AppConfiguration appConfiguration;
         private readonly IStatusTextService statusManager;
+        private readonly ILogger logger;
         private int runningProcesses;
 
         public event EventHandler<int> RunningProcessesChanged;
 
-        public StreamStarterService(IStatusTextService statusManager, AppConfiguration appConfiguration)
+        public StreamStarterService(
+            IStatusTextService statusManager,
+            ILogger logger,
+            AppConfiguration appConfiguration)
         {
             this.statusManager = statusManager;
+            this.logger = logger;
             this.appConfiguration = appConfiguration;
         }
 
@@ -61,7 +66,7 @@ private void StartProcess(string process, string args)
 
             processTemp.Exited += ProcessTemp_Exited;
             processTemp.OutputDataReceived += ProcessTemp_DataReceived;
-            processTemp.ErrorDataReceived += ProcessTemp_DataReceived;
+            processTemp.ErrorDataReceived += ProcessTemp_DataReceivedError;
 
             try
             {
@@ -72,7 +77,9 @@ private void StartProcess(string process, string args)
             }
             catch (Exception e)
             {
-                statusManager.ChangeStatusText($"Error: Could not start process. Exception: {e}");
+                var errorMessage = $"Error: Could not start process. Exception: {e}";
+                statusManager.ChangeStatusText(errorMessage);
+                logger.LogError(errorMessage);
             }
         }
 
@@ -92,5 +99,11 @@ private void ProcessTemp_DataReceived(object sender, DataReceivedEventArgs e)
         {
             statusManager.ChangeStatusText(e.Data, TimeSpan.FromSeconds(2));
         }
+
+        private void ProcessTemp_DataReceivedError(object sender, DataReceivedEventArgs e)
+        {
+            statusManager.ChangeStatusText(e.Data, TimeSpan.FromSeconds(10));
+            logger.LogError(e.Data);
+        }
     }
 }
diff --git a/VattenMedia/ViewModels/MainWindowViewModel.cs b/VattenMedia/ViewModels/MainWindowViewModel.cs
@@ -23,6 +23,7 @@ internal class MainWindowViewModel : BaseViewModel
         private readonly IYoutubeService youtubeService;
         private readonly IStatusTextService statusManager;
         private readonly IStreamStarterService streamStarterService;
+        private readonly ILogger logger;
         private readonly AppConfiguration appConfiguration;
         private int runningProcesses;
         private Timer statusTextTimer;
@@ -58,6 +59,7 @@ public MainWindowViewModel(
             IYoutubeService youtubeService,
             IStatusTextService statusManager,
             IStreamStarterService streamStarterService,
+            ILogger logger,
             AppConfiguration appConfiguration)
         {
             this.viewModelFactory = viewModelFactory;
@@ -67,6 +69,7 @@ public MainWindowViewModel(
             this.statusManager = statusManager;
             statusManager.SetCallback(ChangeStatusText);
             this.streamStarterService = streamStarterService;
+            this.logger = logger;
             this.appConfiguration = appConfiguration;
             streamStarterService.RunningProcessesChanged +=
                 (s, e) => { RunningProcessesChangedHandler(e); };
@@ -110,8 +113,13 @@ private void UpdateRunningProcessesText()
             }
         }
 
-        private void ChangeStatusText(string status, TimeSpan? time = null)
+        private void ChangeStatusText(string status, TimeSpan? time = null, bool isError = false)
         {
+            if (isError)
+            {
+                logger.LogError(status);
+            }
+
             if (statusTextTimer != null && statusTextTimer.Enabled && time != null)
             {
                 statusTextTimer.Stop();
@@ -145,7 +153,9 @@ private async void ListVideos(string channelId)
             }
             catch (Exception e)
             {
-                statusManager.ChangeStatusText($"Error: Failed to get videos from Twitch. Exception: {e}");
+                var errorMessage = $"Error: Failed to get videos from Twitch. Exception: {e}";
+                statusManager.ChangeStatusText(errorMessage);
+                logger.LogError(errorMessage);
             }
             ChangeToVideoListView();
         }
@@ -177,7 +187,9 @@ private async void ListChannels(IStreamingService streamingService, string acces
             }
             catch (Exception e)
             {
-                statusManager.ChangeStatusText($"Error: Failed to get live channels from Twitch. Exception: {e}");
+                var errorMessage = $"Error: Failed to get live channels from Twitch. Exception: {e}";
+                statusManager.ChangeStatusText(errorMessage);
+                logger.LogError(errorMessage);
             }
         }
 
@@ -189,7 +201,7 @@ private void OnLaunchCommand(object uri)
             }
             catch (Exception ex)
             {
-                ChangeStatusText($"Failed to launch stream - {ex}");
+                ChangeStatusText($"Failed to launch stream - {ex}", isError: true);
             }
         }
 
@@ -205,15 +217,15 @@ private void OnLaunchFromUrlCommand(object _)
             }
             catch (Exception ex)
             {
-                ChangeStatusText($"Failed to launch from URL - {ex}");
+                ChangeStatusText($"Failed to launch from URL - {ex}", isError: true);
             }
         }
 
         private void OnOAuthTwitchCommand(object _)
         {
             if (string.IsNullOrEmpty(configHandler.Config.TwitchClientId))
             {
-                ChangeStatusText("Client id missing - cannot authenticate");
+                ChangeStatusText("Client id missing - cannot authenticate", isError: true);
             }
             else
             {
@@ -281,12 +293,12 @@ private void OpenChat(string channelName)
         {
             if (string.IsNullOrEmpty(configHandler.Config.TwitchAccessToken))
             {
-                ChangeStatusText("Access token missing - cannot open chat");
+                ChangeStatusText("Access token missing - cannot open chat", isError: true);
                 return;
             }
             if (string.IsNullOrEmpty(configHandler.Config.TwitchUsername))
             {
-                ChangeStatusText("Username is missing - cannot open chat");
+                ChangeStatusText("Username is missing - cannot open chat", isError: true);
                 return;
             }
             var chatWindow = new ChatView { DataContext = viewModelFactory.CreateChatViewModel() };

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ namespace VattenMedia.Core.Interfaces`
`4`	`4`	`{`
`5`	`5`	`public interface IStatusTextService`
`6`	`6`	`{`
`7`		`- void SetCallback(Action<string, TimeSpan?> changeStatus);`
`8`		`- void ChangeStatusText(string status, TimeSpan? time = null);`
	`7`	`+ void SetCallback(Action<string, TimeSpan?, bool> changeStatus);`
	`8`	`+ void ChangeStatusText(string status, TimeSpan? time = null, bool isError = false);`
`9`	`9`	`}`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ public static void AddInfrastructureRegistrations(this IUnityContainer container`
`16`	`16`	`container.RegisterType<ITwitchService, TwitchService>();`
`17`	`17`	`container.RegisterType<IYoutubeService, YoutubeService>();`
`18`	`18`	`container.RegisterType<ITwitchChatClientFactory, TwitchChatClientFactory>();`
	`19`	`+ container.RegisterType<ILogger, Logger>();`
`19`	`20`	`}`
`20`	`21`	`}`
`21`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,20 +5,20 @@ namespace VattenMedia.Infrastructure.Services`
`5`	`5`	`{`
`6`	`6`	`internal class StatusTextService : IStatusTextService`
`7`	`7`	`{`
`8`		`- private Action<string, TimeSpan?> changeStatus;`
	`8`	`+ private Action<string, TimeSpan?, bool> changeStatus;`
`9`	`9`
`10`	`10`	`public StatusTextService()`
`11`	`11`	`{`
`12`	`12`	`}`
`13`	`13`
`14`		`- public void SetCallback(Action<string, TimeSpan?> changeStatus)`
	`14`	`+ public void SetCallback(Action<string, TimeSpan?, bool> changeStatus)`
`15`	`15`	`{`
`16`		`- this.changeStatus = changeStatus;`
	`16`	`+ this.changeStatus = changeStatus;`
`17`	`17`	`}`
`18`	`18`
`19`		`- public void ChangeStatusText(string status, TimeSpan? time = null)`
	`19`	`+ public void ChangeStatusText(string status, TimeSpan? time = null, bool isError = false)`
`20`	`20`	`{`
`21`		`- changeStatus(status, time);`
	`21`	`+ changeStatus(status, time, isError);`
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,13 +10,18 @@ internal class StreamStarterService : IStreamStarterService`
`10`	`10`	`{`
`11`	`11`	`private readonly AppConfiguration appConfiguration;`
`12`	`12`	`private readonly IStatusTextService statusManager;`
	`13`	`+ private readonly ILogger logger;`
`13`	`14`	`private int runningProcesses;`
`14`	`15`
`15`	`16`	`public event EventHandler<int> RunningProcessesChanged;`
`16`	`17`
`17`		`- public StreamStarterService(IStatusTextService statusManager, AppConfiguration appConfiguration)`
	`18`	`+ public StreamStarterService(`
	`19`	`+ IStatusTextService statusManager,`
	`20`	`+ ILogger logger,`
	`21`	`+ AppConfiguration appConfiguration)`
`18`	`22`	`{`
`19`	`23`	`this.statusManager = statusManager;`
	`24`	`+ this.logger = logger;`
`20`	`25`	`this.appConfiguration = appConfiguration;`
`21`	`26`	`}`
`22`	`27`
`@@ -61,7 +66,7 @@ private void StartProcess(string process, string args)`
`61`	`66`
`62`	`67`	`processTemp.Exited += ProcessTemp_Exited;`
`63`	`68`	`processTemp.OutputDataReceived += ProcessTemp_DataReceived;`
`64`		`- processTemp.ErrorDataReceived += ProcessTemp_DataReceived;`
	`69`	`+ processTemp.ErrorDataReceived += ProcessTemp_DataReceivedError;`
`65`	`70`
`66`	`71`	`try`
`67`	`72`	`{`
`@@ -72,7 +77,9 @@ private void StartProcess(string process, string args)`
`72`	`77`	`}`
`73`	`78`	`catch (Exception e)`
`74`	`79`	`{`
`75`		`- statusManager.ChangeStatusText($"Error: Could not start process. Exception: {e}");`
	`80`	`+ var errorMessage = $"Error: Could not start process. Exception: {e}";`
	`81`	`+ statusManager.ChangeStatusText(errorMessage);`
	`82`	`+ logger.LogError(errorMessage);`
`76`	`83`	`}`
`77`	`84`	`}`
`78`	`85`
`@@ -92,5 +99,11 @@ private void ProcessTemp_DataReceived(object sender, DataReceivedEventArgs e)`
`92`	`99`	`{`
`93`	`100`	`statusManager.ChangeStatusText(e.Data, TimeSpan.FromSeconds(2));`
`94`	`101`	`}`
	`102`	`+`
	`103`	`+ private void ProcessTemp_DataReceivedError(object sender, DataReceivedEventArgs e)`
	`104`	`+ {`
	`105`	`+ statusManager.ChangeStatusText(e.Data, TimeSpan.FromSeconds(10));`
	`106`	`+ logger.LogError(e.Data);`
	`107`	`+ }`
`95`	`108`	`}`
`96`	`109`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ internal class MainWindowViewModel : BaseViewModel`
`23`	`23`	`private readonly IYoutubeService youtubeService;`
`24`	`24`	`private readonly IStatusTextService statusManager;`
`25`	`25`	`private readonly IStreamStarterService streamStarterService;`
	`26`	`+ private readonly ILogger logger;`
`26`	`27`	`private readonly AppConfiguration appConfiguration;`
`27`	`28`	`private int runningProcesses;`
`28`	`29`	`private Timer statusTextTimer;`
`@@ -58,6 +59,7 @@ public MainWindowViewModel(`
`58`	`59`	`IYoutubeService youtubeService,`
`59`	`60`	`IStatusTextService statusManager,`
`60`	`61`	`IStreamStarterService streamStarterService,`
	`62`	`+ ILogger logger,`
`61`	`63`	`AppConfiguration appConfiguration)`
`62`	`64`	`{`
`63`	`65`	`this.viewModelFactory = viewModelFactory;`
`@@ -67,6 +69,7 @@ public MainWindowViewModel(`
`67`	`69`	`this.statusManager = statusManager;`
`68`	`70`	`statusManager.SetCallback(ChangeStatusText);`
`69`	`71`	`this.streamStarterService = streamStarterService;`
	`72`	`+ this.logger = logger;`
`70`	`73`	`this.appConfiguration = appConfiguration;`
`71`	`74`	`streamStarterService.RunningProcessesChanged +=`
`72`	`75`	`(s, e) => { RunningProcessesChangedHandler(e); };`
`@@ -110,8 +113,13 @@ private void UpdateRunningProcessesText()`
`110`	`113`	`}`
`111`	`114`	`}`
`112`	`115`
`113`		`- private void ChangeStatusText(string status, TimeSpan? time = null)`
	`116`	`+ private void ChangeStatusText(string status, TimeSpan? time = null, bool isError = false)`
`114`	`117`	`{`
	`118`	`+ if (isError)`
	`119`	`+ {`
	`120`	`+ logger.LogError(status);`
	`121`	`+ }`
	`122`	`+`
`115`	`123`	`if (statusTextTimer != null && statusTextTimer.Enabled && time != null)`
`116`	`124`	`{`
`117`	`125`	`statusTextTimer.Stop();`
`@@ -145,7 +153,9 @@ private async void ListVideos(string channelId)`
`145`	`153`	`}`
`146`	`154`	`catch (Exception e)`
`147`	`155`	`{`
`148`		`- statusManager.ChangeStatusText($"Error: Failed to get videos from Twitch. Exception: {e}");`
	`156`	`+ var errorMessage = $"Error: Failed to get videos from Twitch. Exception: {e}";`
	`157`	`+ statusManager.ChangeStatusText(errorMessage);`
	`158`	`+ logger.LogError(errorMessage);`
`149`	`159`	`}`
`150`	`160`	`ChangeToVideoListView();`
`151`	`161`	`}`
`@@ -177,7 +187,9 @@ private async void ListChannels(IStreamingService streamingService, string acces`
`177`	`187`	`}`
`178`	`188`	`catch (Exception e)`
`179`	`189`	`{`
`180`		`- statusManager.ChangeStatusText($"Error: Failed to get live channels from Twitch. Exception: {e}");`
	`190`	`+ var errorMessage = $"Error: Failed to get live channels from Twitch. Exception: {e}";`
	`191`	`+ statusManager.ChangeStatusText(errorMessage);`
	`192`	`+ logger.LogError(errorMessage);`
`181`	`193`	`}`
`182`	`194`	`}`
`183`	`195`
`@@ -189,7 +201,7 @@ private void OnLaunchCommand(object uri)`
`189`	`201`	`}`
`190`	`202`	`catch (Exception ex)`
`191`	`203`	`{`
`192`		`- ChangeStatusText($"Failed to launch stream - {ex}");`
	`204`	`+ ChangeStatusText($"Failed to launch stream - {ex}", isError: true);`
`193`	`205`	`}`
`194`	`206`	`}`
`195`	`207`
`@@ -205,15 +217,15 @@ private void OnLaunchFromUrlCommand(object _)`
`205`	`217`	`}`
`206`	`218`	`catch (Exception ex)`
`207`	`219`	`{`
`208`		`- ChangeStatusText($"Failed to launch from URL - {ex}");`
	`220`	`+ ChangeStatusText($"Failed to launch from URL - {ex}", isError: true);`
`209`	`221`	`}`
`210`	`222`	`}`
`211`	`223`
`212`	`224`	`private void OnOAuthTwitchCommand(object _)`
`213`	`225`	`{`
`214`	`226`	`if (string.IsNullOrEmpty(configHandler.Config.TwitchClientId))`
`215`	`227`	`{`
`216`		`- ChangeStatusText("Client id missing - cannot authenticate");`
	`228`	`+ ChangeStatusText("Client id missing - cannot authenticate", isError: true);`
`217`	`229`	`}`
`218`	`230`	`else`
`219`	`231`	`{`
`@@ -281,12 +293,12 @@ private void OpenChat(string channelName)`
`281`	`293`	`{`
`282`	`294`	`if (string.IsNullOrEmpty(configHandler.Config.TwitchAccessToken))`
`283`	`295`	`{`
`284`		`- ChangeStatusText("Access token missing - cannot open chat");`
	`296`	`+ ChangeStatusText("Access token missing - cannot open chat", isError: true);`
`285`	`297`	`return;`
`286`	`298`	`}`
`287`	`299`	`if (string.IsNullOrEmpty(configHandler.Config.TwitchUsername))`
`288`	`300`	`{`
`289`		`- ChangeStatusText("Username is missing - cannot open chat");`
	`301`	`+ ChangeStatusText("Username is missing - cannot open chat", isError: true);`
`290`	`302`	`return;`
`291`	`303`	`}`
`292`	`304`	`var chatWindow = new ChatView { DataContext = viewModelFactory.CreateChatViewModel() };`