Skip to content

Commit 07f15ef

Browse files
authoredOct 15, 2024
JIT: Stop calling morph from CSE (dotnet#106695)
CSE cannot tolerate morph removing any defs, which many of morphs transformations can do. We have been slowly infecting morph with more and more checks to avoid this, but in reality CSE just should not reinvoke morph -- the benefits of doing this are minimal.
1 parent 74857d7 commit 07f15ef

File tree

5 files changed

+136
-248
lines changed

5 files changed

+136
-248
lines changed
 

‎src/coreclr/jit/compiler.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6944,7 +6944,6 @@ class Compiler
69446944
TypeProducerKind gtGetTypeProducerKind(GenTree* tree);
69456945
bool gtIsTypeHandleToRuntimeTypeHelper(GenTreeCall* call);
69466946
bool gtIsTypeHandleToRuntimeTypeHandleHelper(GenTreeCall* call, CorInfoHelpFunc* pHelper = nullptr);
6947-
bool gtIsActiveCSE_Candidate(GenTree* tree);
69486947

69496948
bool gtTreeContainsOper(GenTree* tree, genTreeOps op);
69506949
ExceptionSetFlags gtCollectExceptions(GenTree* tree);

‎src/coreclr/jit/gentree.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17653,11 +17653,6 @@ bool Compiler::gtIsTypeHandleToRuntimeTypeHandleHelper(GenTreeCall* call, CorInf
1765317653
return helper != CORINFO_HELP_UNDEF;
1765417654
}
1765517655

17656-
bool Compiler::gtIsActiveCSE_Candidate(GenTree* tree)
17657-
{
17658-
return (optValnumCSE_phase && IS_CSE_INDEX(tree->gtCSEnum));
17659-
}
17660-
1766117656
//------------------------------------------------------------------------
1766217657
// gtTreeContainsOper -- check if the tree contains any subtree with the specified oper.
1766317658
//

0 commit comments

Comments
 (0)