Skip to content

Commit 0194044

Browse files
Merge PR #442 - update devcontainer image
The devcontainer image stopped working because the requested Ubuntu image was too outdated. This pull request brings it up to date and it should remain functional until 2029. It also enables use of the emulator by installing the needed dependencies. Reviewed-by: Matheus Afonso Martins Moreira <matheus@matheusmoreira.com> GitHub-Pull-Request: #442
2 parents 0ad5fa4 + f02e73c commit 0194044

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.devcontainer/Dockerfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
FROM ubuntu:22.10
2-
3-
# TODO: install emscripten (https://emscripten.org/docs/getting_started/downloads.html)
1+
FROM ubuntu:24.04
42

53
# TODO: Clean this up once buildkit is supported gracefully in devcontainers
64
# https://github.com/microsoft/vscode-remote-release/issues/1409
@@ -27,7 +25,9 @@ RUN apt-get update \
2725
# ca certs need to be available for fetching git submodules
2826
ca-certificates \
2927
# python is used to convert binaries to uf2 files
30-
python3 python-is-python3
28+
python3 python-is-python3 \
29+
# emscripten for building simulator
30+
emscripten
3131

3232
# Download and verify both x86-64 and aarch64 toolchains. This is unfortunate and
3333
# slows down the build, but it's a clean-ish option until buildkit can be used.
@@ -47,4 +47,4 @@ RUN /bin/sh -c 'set -ex && \
4747
fi'
4848

4949
RUN rm $X86_64_TOOLCHAIN_FILENAME
50-
RUN rm $AARCH64_TOOLCHAIN_FILENAME
50+
RUN rm $AARCH64_TOOLCHAIN_FILENAME

0 commit comments

Comments
 (0)