Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to remove title and borders #239

Open
celiopassos opened this issue Jul 18, 2017 · 3 comments
Open

Add an option to remove title and borders #239

celiopassos opened this issue Jul 18, 2017 · 3 comments

Comments

@celiopassos
Copy link

celiopassos commented Jul 18, 2017

Most of the times, the markdown file already possesses a header/title and, as such, it is isn't necessary to show another title.

The borders don't look good when I print the page as a pdf (there is no top or bottom borders when pages are split) and so it would be good to have an option to disable borders.

@dylan-robins
Copy link

Was thinking of this yesterday. My current work around is modifying the html/CSS using Inspect Element in my browser, and then printing to pdf, but it's rather cluncky, especially if you have multiple files to print.
I'll be taking a look at the source code in a couple of weeks, once I'm out of uni, so I'll try to add this (if I can).

@celiopassos
Copy link
Author

@dylan-robins I managed to do it, forgot to mention it here, although the automated tests failed, see #240.

@davestewart
Copy link

davestewart commented Nov 27, 2018

Surely the default should just be a print stylesheet?

@media print {

  #preview-page {
    margin: 0;
  }

  .repository-content > div > h3 {
    display: none;
  }

  .markdown-body.entry-content {
    padding: 0;
    border: 0;
  }
  
}

davestewart added a commit to davestewart/grip that referenced this issue Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants