Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitLab Markdown preview? #283

Open
wuweiweiwu opened this issue Oct 29, 2018 · 6 comments
Open

Support GitLab Markdown preview? #283

wuweiweiwu opened this issue Oct 29, 2018 · 6 comments

Comments

@wuweiweiwu
Copy link

AFAIK its very similar. Some minor syntactic differences

@joeyespo
Copy link
Owner

joeyespo commented Oct 29, 2018

Sounds good. Do you happen to know if GitLab offers an API for their Markdown rendering? If so, we could add a new GitLabRenderer (similar to GitHubRenderer).

@wuweiweiwu
Copy link
Author

I believe so! https://docs.gitlab.com/ee/api/markdown.html

I'll be happy to pick this up and work on it in the coming weeks

@joeyespo
Copy link
Owner

joeyespo commented Oct 29, 2018

Perfect!

Awesome. If you do, I'll be happy to get it in. Likely with a --gitlab argument for now since this project is still mainly a GitHub project. I do think it's beneficial to keep it focused. If the implementation gets complex, feel free to comment on that here and we can try to find a way to improve the internals first.

Thanks for offering 😃

@roosemberth
Copy link

Hi, I wonder what's the state of the issue?

@wuweiweiwu
Copy link
Author

wuweiweiwu commented Feb 24, 2019

I havent had the time to make this particular change. I'd try to get it in when i have the bandwidth but feel free to pick it up! :)

@Lucas-C
Copy link

Lucas-C commented Jun 25, 2020

FYI, a PR was submitted to provide this : #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants