Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grip --quiet does not seem to be quiet #293

Open
ABrambleNinja opened this issue Apr 28, 2019 · 1 comment · May be fixed by #308
Open

grip --quiet does not seem to be quiet #293

ABrambleNinja opened this issue Apr 28, 2019 · 1 comment · May be fixed by #308
Labels
bug help-wanted

Comments

@ABrambleNinja
Copy link

Hi,
Firstly, thanks for making this! I really appreciate this utility.

When I run grip doc/api-spec.md, it functions as expected:

$ grip doc/api-spec.md 
 * Serving Flask app "grip.app" (lazy loading)
 * Environment: production
   WARNING: Do not use the development server in a production environment.
   Use a production WSGI server instead.
 * Debug mode: off
 * Running on http://localhost:6419/ (Press CTRL+C to quit)

However, when I give it the --quiet flag, it prints all of the above minus one line:

$ grip doc/api-spec.md --quiet
 * Serving Flask app "grip.app" (lazy loading)
 * Environment: production
   WARNING: Do not use the development server in a production environment.
   Use a production WSGI server instead.
 * Debug mode: off

I'm happy to submit a PR to fix this if this isn't intended behavior (if it is, then that's totally fine, just wanted to know!)
@joeyespo
Copy link
Owner

Yeah, I'd consider this a bug. Happy to take a fix. (Note that these messages come from Flask / Werkzeug.)

Thanks for the issue, @ABrambleNinja!

@harrywhite4 harrywhite4 linked a pull request Oct 28, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help-wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make --quiet more quiet harrywhite4/grip
2 participants
@joeyespo @ABrambleNinja