Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug? rhythm affects rate of arpeggio #108

Open
M0ahgra opened this issue Sep 9, 2024 · 3 comments
Open

bug? rhythm affects rate of arpeggio #108

M0ahgra opened this issue Sep 9, 2024 · 3 comments

Comments

@M0ahgra
Copy link

M0ahgra commented Sep 9, 2024

selected rhythm type affects rate of arpeggio, im not sure if this is intended

@M0ahgra
Copy link
Author

M0ahgra commented Sep 13, 2024

this reminds me of when i saw some user mention that changing the rhythm type retimes the entire song, this is likely part of what causes the arpeggio rate to change too

@Mid-The-Modder
Copy link

Seems to be intentional according to the code, in which each rhythm has a parameter passed in called ticksPerArpeggio which is either 3 or 4, which is what is causing the speed change on certain rhythms.
https://github.com/johnnesky/beepbox/blob/6cbeaf11bc9d8b2b31d475f15d1728c0e9f29c6c/synth/SynthConfig.ts#L272C2-L278C5

@M0ahgra
Copy link
Author

M0ahgra commented Sep 21, 2024

rhythm doesnt feel like a part of the song, it feels like an edit mode, this is probably because u do infact have to change the rhythm to change the length of notes placed, so it can easily b mistaken for being an editing tool. it can b very easy to forget to put it back after youve changed the rhythm mode to place different length notes, leaving your arpeggios sounding different than u may have wanted! i think this should b changed, maybe separate rhythm mode into a rhythm editing mode, and another to set things like speed of arpeggios. btw all the rhythms have their own speeds, 3x 4x 6x 8x all have diff speeds. because rhythm is a setting used to edit notes and also set arpeggio speed, it can create confusion imo, and it is kinda weird, its the only thing in beepbox i can think of that is both a setting and a part of the exported song!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants