From 6fcee32062b1f0631cc1a217cdd564aa2379459d Mon Sep 17 00:00:00 2001 From: John Ryan Date: Tue, 24 May 2022 09:10:56 -0700 Subject: [PATCH 1/3] Add testing workflow --- .github/workflows/flutter.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 .github/workflows/flutter.yml diff --git a/.github/workflows/flutter.yml b/.github/workflows/flutter.yml new file mode 100644 index 0000000..3f1321e --- /dev/null +++ b/.github/workflows/flutter.yml @@ -0,0 +1,14 @@ +name: Flutter CI +on: push +jobs: + test-package: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v1 + - uses: subosito/flutter-action@v1 + with: + channel: 'stable' + - run: flutter pub get + - run: flutter format --set-exit-if-changed . + - run: flutter analyze . + - run: flutter test \ No newline at end of file From c01f6860d42f7bb09858e30782ee97caa8ba352b Mon Sep 17 00:00:00 2001 From: John Ryan Date: Tue, 24 May 2022 11:13:15 -0700 Subject: [PATCH 2/3] remove print --- example/lib/cupertino.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/example/lib/cupertino.dart b/example/lib/cupertino.dart index cc839e4..7ed0ffa 100644 --- a/example/lib/cupertino.dart +++ b/example/lib/cupertino.dart @@ -67,7 +67,6 @@ int _selectedIndex(BuildContext context) { final route = RouteState.of(context)!; final activeChild = route.activeChild; if (activeChild != null) { - print('activeChild.path = ${activeChild.path}'); if (activeChild.path == 'home') return 0; if (activeChild.path == 'chat') return 1; if (activeChild.path == 'profile') return 2; From 9fcf2b65efcf091fa3427a5ab71bfe929d3d3ca4 Mon Sep 17 00:00:00 2001 From: John Ryan Date: Tue, 24 May 2022 13:23:13 -0700 Subject: [PATCH 3/3] use thumbVisibility API --- example/lib/recursive_shell.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example/lib/recursive_shell.dart b/example/lib/recursive_shell.dart index 90faf93..451eb31 100644 --- a/example/lib/recursive_shell.dart +++ b/example/lib/recursive_shell.dart @@ -105,7 +105,7 @@ class _AppScaffoldState extends State { return Scaffold( body: SafeArea( child: Scrollbar( - isAlwaysShown: true, + thumbVisibility: true, controller: _scrollController, child: LayoutBuilder( builder: (context, viewportConstraints) {