Skip to content

Commit 64433f4

Browse files
authored
Remove DiscoveredPathContainerPage (eclipse-cdt#701)
The class DiscoveredPathContainerPage used a number of APIs in the Eclipse Platform [removed](eclipse-platform/eclipse.platform.ui#1563) in [Eclipse 4.31 release](https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/81e406456ffae2f82fe0bb244adfdc4121c9e463/eclipse.platform.common/bundles/org.eclipse.platform.doc.isv/porting/removals.html#L595). This class, while API, has not be used, nor usable since the CDT 4 release as it was only for CDT 3.x style projects. The class had been deprecated since 2010. To mitigate against the possibility that someone may have a dependency on this old class the minor version has been bumped so that version range can have `,8.3)` as their upper version. Fixes eclipse-cdt#700
1 parent 70dbde4 commit 64433f4

File tree

5 files changed

+28
-819
lines changed

5 files changed

+28
-819
lines changed

NewAndNoteworthy/CHANGELOG-API.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@ This section describes API removals that occurred in past releases, and upcoming
88

99
Below is the detailed descriptions of API changes and mitigation efforts API consumers need to take.
1010

11+
## API Changes in CDT 11.5.
12+
13+
### org.eclipse.cdt.make.ui.dialogs.DiscoveredPathContainerPage removed
14+
15+
The class DiscoveredPathContainerPage used a number of APIs in the Eclipse Platform [removed](https://github.com/eclipse-platform/eclipse.platform.ui/pull/1563) in [Eclipse 4.31 release](https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/81e406456ffae2f82fe0bb244adfdc4121c9e463/eclipse.platform.common/bundles/org.eclipse.platform.doc.isv/porting/removals.html#L595).
16+
This class, while API, has not be used, nor usable since the CDT 4 release as it was only for CDT 3.x style projects.
17+
The class had been deprecated since 2010.
18+
1119
## API Changes in CDT 11.4.
1220

1321
### org.eclipse.tools.templates.freemarker, org.eclipse.tools.templates.freemarker.ui and org.eclipse.tools.templates.freemarker.core major version bumped
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
2+
<component id="org.eclipse.cdt.make.ui" version="2">
3+
<resource path="META-INF/MANIFEST.MF">
4+
<filter comment="This class references deleted classes in Platform and this class is not reachable See https://github.com/eclipse-cdt/cdt/issues/700" id="923795461">
5+
<message_arguments>
6+
<message_argument value="8.3.0"/>
7+
<message_argument value="8.2.100"/>
8+
</message_arguments>
9+
</filter>
10+
</resource>
11+
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.cdt.make.ui.dialogs.DiscoveredPathContainerPage">
12+
<filter comment="This class references deleted classes in Platform and this class is not reachable See https://github.com/eclipse-cdt/cdt/issues/700" id="305324134">
13+
<message_arguments>
14+
<message_argument value="org.eclipse.cdt.make.ui.dialogs.DiscoveredPathContainerPage"/>
15+
<message_argument value="org.eclipse.cdt.make.ui_8.3.0"/>
16+
</message_arguments>
17+
</filter>
18+
</resource>
19+
</component>

build/org.eclipse.cdt.make.ui/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: %pluginName
44
Bundle-SymbolicName: org.eclipse.cdt.make.ui; singleton:=true
5-
Bundle-Version: 8.2.100.qualifier
5+
Bundle-Version: 8.3.0.qualifier
66
Bundle-Activator: org.eclipse.cdt.make.internal.ui.MakeUIPlugin
77
Bundle-Vendor: %providerName
88
Bundle-Localization: plugin

build/org.eclipse.cdt.make.ui/plugin.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -430,14 +430,6 @@
430430
</extension>
431431

432432

433-
<extension
434-
point="org.eclipse.cdt.ui.PathContainerPage">
435-
<PathContainerPage
436-
class="org.eclipse.cdt.make.ui.dialogs.DiscoveredPathContainerPage"
437-
icon="icons/obj16/lib_obj.gif"
438-
id="org.eclipse.cdt.make.core.DISCOVERED_SCANNER_INFO"
439-
name="%DiscoveredScannerInfoContainer.name"/>
440-
</extension>
441433
<extension
442434
point="org.eclipse.core.runtime.preferences">
443435
<initializer class="org.eclipse.cdt.make.internal.ui.MakeUIPreferenceInitializer"/>

0 commit comments

Comments
 (0)