Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the ViennaGrid source code in the repository / tarballs #3

Open
genba opened this issue Oct 1, 2013 · 0 comments
Open

Include the ViennaGrid source code in the repository / tarballs #3

genba opened this issue Oct 1, 2013 · 0 comments

Comments

@genba
Copy link
Contributor

genba commented Oct 1, 2013

We must think of a better way to include the ViennaGrid source code to make compilation easier.

Currently, the source code of ViennaGrid, on which ViennaGrid for Python depends, is included in the repository as a Git submodule. This is fine if the user gets and compiles the code from the repository, because they can also fetch the ViennaGrid code either by cloning and updating the submodules:

git clone https://github.com/genba/viennagrid-python.git
cd viennagrid-python/
git submodule init
git submodule update

or just by cloning with the --recursive option:

git clone --recursive https://github.com/genba/viennagrid-python.git

and they will be able to compile ViennaGrid for Python.

However, if the user downloads a tarball, the Git repository information will not be included in the tarball, and thus no submodule information will be available. In other words, the user will have to download ViennaGrid by themselves.

The script bootstrap.py intends to aid the user in this task, but it currently only updates the submodules; it doesn't download ViennaGrid separately. This must be fixed, so that the script download ViennaGrid separately when no Git repository information is available.

Besides, other approaches could be search, for example, with the ExternalProject_Add command of CMake.

@ghost ghost assigned genba Oct 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant