-
-
Notifications
You must be signed in to change notification settings - Fork 18
Open
Description
There are many things I would like to change:
- Uses
arr-diff/benchmark/code/filter.js
Line 3 in ea84b7d
module.exports = function diff(arr, arrays) { functioninstead of arrow function - Uses
arr-diff/benchmark/code/filter.js
Line 3 in ea84b7d
module.exports = function diff(arr, arrays) { arraysfor a parameter, but is actually used likeconst arrays =. Usesarguments, when it could use...arrays. - This is a really wierd line. Can just use
arr-diff/benchmark/code/filter.js
Line 4 in ea84b7d
arrays = [].concat.apply([], [].slice.call(arguments, 1)); [].concat()instead of[].concat.apply(). Uses[].slicewhenArray.prototype.slicemakes more sense. - Can use
arr-diff/benchmark/code/filter.js
Line 6 in ea84b7d
return arrays.indexOf(ele) === -1; includesinstead ofindexOf
Can I make a pull request changing this? Should I add a new benchmark or edit the existing one?
Metadata
Metadata
Assignees
Labels
No labels