Skip to content

[4.0] Fixing phpstan error and adding baseline #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdeutz merged 1 commit into from
Jul 4, 2025
Merged

[4.0] Fixing phpstan error and adding baseline #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
.github/ export-ignore
.phan/ export-ignore
docs/ export-ignore
Tests/ export-ignore
.drone.jsonnet export-ignore
.drone.yml export-ignore
.editorconfig export-ignore
.gitattributes export-ignore
.gitignore export-ignore
.phpunit.cache export-ignore
phpunit.xml.dist export-ignore
rector.php export-ignore
ruleset.xml export-ignore
phpstan.neon export-ignore
phpstan-baseline.neon export-ignore
19 changes: 19 additions & 0 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
parameters:
ignoreErrors:
-
message: '#^Call to function is_int\(\) with int will always evaluate to true\.$#'
identifier: function.alreadyNarrowedType
count: 1
path: src/AbstractWebApplication.php

-
message: '#^Instanceof between DateTime and DateTime will always evaluate to true\.$#'
identifier: instanceof.alwaysTrue
count: 1
path: src/AbstractWebApplication.php

-
message: '#^Result of && is always false\.$#'
identifier: booleanAnd.alwaysFalse
count: 1
path: src/AbstractWebApplication.php
1 change: 1 addition & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@

includes:
- vendor/phpstan/phpstan-deprecation-rules/rules.neon
- phpstan-baseline.neon

parameters:
level: 5
Expand Down
2 changes: 1 addition & 1 deletion src/AbstractWebApplication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ protected function compress()

// Iterate through the encodings and attempt to compress the data using any found supported encodings.
foreach ($encodings as $encoding) {
if (($supported[$encoding] == 'gz') || ($supported[$encoding] == 'deflate')) {
if (in_array($supported[$encoding], ['gz', 'deflate'])) {
// Verify that the server supports gzip compression before we attempt to gzip encode the data.
// @codeCoverageIgnoreStart
if (!\extension_loaded('zlib') || \ini_get('zlib.output_compression')) {
Expand Down
Loading