Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

title attribute #64

Closed
brianteeman opened this issue Mar 21, 2019 · 3 comments
Closed

title attribute #64

brianteeman opened this issue Mar 21, 2019 · 3 comments

Comments

@brianteeman
Copy link

I made a start today on removing the generally useless title attribute.

So far I only removed the title attribute where it is the same as the visible text.

We have a lot like this though.


<th scope="row">
	<span class="icon-eye-close disabled hasTooltip" aria-hidden="true" title="No preview available. You can enable preview in the options."></span>
	<span class="sr-only">No preview available. You can enable preview in the options.</span>
	<a href="/joomla-cms/administrator/index.php?option=com_templates&amp;task=style.edit&amp;id=11" title="Edit cassiopeia - Default">
	<span class="fa fa-pencil-square mr-2" aria-hidden="true"></span>cassiopeia - Default</a>
</th>

This one piece of code has two examples of issues. Suggestions on how to handle these

@maliouris
Copy link

As I read here #52 we need titles in order to have an alternative way to understand what an icon represents if we just can't or for some reason it doesn't load

@brianteeman
Copy link
Author

But what happens for a screenreader in the second example? Do they hear it twice?

@zwiastunsw
Copy link
Contributor

NVDA reads: "No preview available. You can enable preview in the options. Link cassiopeia - default"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants