Unable to upload files when PHP post_max_size is set to 0

[johnrix]

Steps to reproduce the issue

1. Update php.ini file to set post_max_size to 0 (and restart PHP/Apache)
2. Attempt to upload any extension from the Upload Package File tab on the Manage Extensions page

Expected result

Extension should be uploaded and deployed successfully.

Actual result

Upload fails instant with the following message:

"The selected file cannot be uploaded as it is bigger than the maximum upload size."

System information (as much as possible)

Ubuntu 22.04.4 LTS
Apache/2.4.52 (Ubuntu)
PHP 8.3.8 (using FPM)
Joomla 5.3.2

Additional comments

The problem appears to be within Joomla\Filesystem\Helper::getFileUploadMaxSize(), and specifically this clause:

$maxSize === 0

$maxSize is previously assign as follows, which results in a float value according to the return type of self::parseSize():

$maxSize = self::parseSize(\ini_get('post_max_size'));

Comparing $maxSize to an integer value (0) consequently fails. Hence, the return value of the function is 0, preventing any file being uploaded.

[richard67]

@johnrix Could you post the issue there https://github.com/joomla-framework/filesystem/issues , too? You can include a reference (mention or of link to) this issue here. Thanks in advance.

Update: Not necessary anymore, see next comment below.

[richard67]

@johnrix Could you test the changes from joomla-framework/filesystem#78 ?

If yes, please test and report back the result in a comment there.

We should leave this issue here open until the fix has been merged and a new release of the filesystem framework has been made and fetched into the CMS. That will probably not happen for 5.3 but for 5.4 (and 6.0).

[johnrix]

@richard67 That was quick! I have applied the edits from your link there and confirmed it works correctly with those in place. 👍

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45905.}

[richard67]

@johnrix Could you put that comment also here? joomla-framework/filesystem#78

[richard67]

New releases 3.1.3 and 4.0.1 have been made for the filesystem package in the framework.

But it may take a while until I will make PRs (one for 5.4-dev and one for 6.0-dev) to fetch that into the CMS as we will so another dependency update anyway, which might be after the beta 1 releases next week.

[Satish-Medar]

@richard67 I’m happy to work on this issue. Could you please assign it to me?

[brianteeman]

@Satish-Medar Thanks for your interest - we do not assign issues. Anyone is free to submit a pull request
PLEASE STOP SPAMMING

[richard67]

@richard67 I’m happy to work on this issue. Could you please assign it to me?

@Satish-Medar As already said in the other issue: We do not assign issues. Please stop to annoy maintainers by notifications. Thanks in advance.

[richard67]

@Satish-Medar P.S.: If you would have read my comment above you would know that the issue is already fixed in the framework and that I will prepare a PR to update that dependency: #45905 (comment)

It is nothing which can be fixed in the CMS code.

So please check comments to issues before proposing to work on them.

[richard67]

For 5.3 (and 5.4) please test PR #45986 . Separate PR for 6.0 will come soon. I'll leave this issue open until that is done.