Skip to content

[small]Feature/83 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josdem merged 4 commits into from
Mar 18, 2025
Merged

[small]Feature/83 #123

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f52636a
83 Adding directory does not exist test
josdem Mar 17, 2025
6388bf1
83 Avoid duplicated code
josdem Mar 17, 2025
7af7217
83 Adding user selects cancel button
josdem Mar 17, 2025
1b18708
83 Adding happy path scenario to the test
josdem Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 61 additions & 4 deletions src/test/java/com/josdem/jmetadata/controller/MetadataControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,11 @@
import static org.mockito.Mockito.when;

import com.josdem.jmetadata.event.Events;
import com.josdem.jmetadata.model.Metadata;
import com.josdem.jmetadata.model.Model;
import com.josdem.jmetadata.service.MetadataService;
import java.io.File;
import java.util.Arrays;
import java.util.Collections;
import java.util.Properties;
import javax.swing.*;
Expand Down Expand Up @@ -57,12 +60,12 @@ void setup() {

@Test
@DisplayName("informing user selected an empty directory")
void shouldGetMetadata(TestInfo testInfo) throws Exception {
void shouldInformEmptyDirectory(TestInfo testInfo) throws Exception {
log.info(testInfo.getDisplayName());
when(fileChooser.showOpenDialog(null)).thenReturn(JFileChooser.APPROVE_OPTION);
when(fileChooser.getSelectedFile()).thenReturn(file);

setFileChooserExpectations();

when(file.exists()).thenReturn(true);
when(configurator.getControlEngine()).thenReturn(controlEngine);
when(metadataService.extractMetadata(file)).thenReturn(Collections.emptyList());

metadataController.getMetadata();
Expand All @@ -72,4 +75,58 @@ void shouldGetMetadata(TestInfo testInfo) throws Exception {
.fireEvent(Events.DIRECTORY_SELECTED, new ValueEvent<>(file.getAbsolutePath()));
verify(controlEngine).fireEvent(Events.DIRECTORY_EMPTY);
}

@Test
@DisplayName("informing user the directory does not exist")
void shouldInformDirectoryDoesNotExist(TestInfo testInfo) {
log.info(testInfo.getDisplayName());
setFileChooserExpectations();
when(file.exists()).thenReturn(false);

metadataController.getMetadata();

verify(fileChooser).setFileSelectionMode(JFileChooser.FILES_AND_DIRECTORIES);
verify(controlEngine).fireEvent(Events.DIRECTORY_NOT_EXIST, new ValueEvent<>(file.toString()));
}

@Test
@DisplayName("validating user selects cancel option")
void shouldValidateUserSelectsCancelOption(TestInfo testInfo) {
log.info(testInfo.getDisplayName());
setFileChooserExpectations();
when(fileChooser.showOpenDialog(null)).thenReturn(JFileChooser.CANCEL_OPTION);

metadataController.getMetadata();

verify(controlEngine).fireEvent(Events.DIRECTORY_SELECTED_CANCEL);
}

@Test
@DisplayName("getting metadata")
void shouldGetMetadata(TestInfo testInfo) throws Exception {
log.info(testInfo.getDisplayName());

setFileChooserExpectations();

when(file.exists()).thenReturn(true);
var metadata1 = new Metadata();
var metadata2 = new Metadata();
metadata1.setTitle("Wish you were here");
metadata2.setTitle("The man who sold the world");
var metadataList = Arrays.asList(metadata1, metadata2);
when(metadataService.extractMetadata(file)).thenReturn(metadataList);

metadataController.getMetadata();

verify(fileChooser).setFileSelectionMode(JFileChooser.FILES_AND_DIRECTORIES);
verify(controlEngine).set(Model.METADATA, metadataList, null);
verify(controlEngine).fireEvent(Events.LOAD, new ValueEvent<>(metadataList));
verify(controlEngine).fireEvent(Events.LOADED);
}

private void setFileChooserExpectations() {
when(fileChooser.showOpenDialog(null)).thenReturn(JFileChooser.APPROVE_OPTION);
when(fileChooser.getSelectedFile()).thenReturn(file);
when(configurator.getControlEngine()).thenReturn(controlEngine);
}
}