Improve error messages to specify which configuration is missing

Co-authored-by: joshjohanning <19912012+joshjohanning@users.noreply.github.com>

Author: Copilot

__tests__/action.test.sh

@@ -279,20 +279,30 @@ test_azdo_config_validation() {
     # Test when both org and PAT are set (valid)
     ORG="my-org"
     PAT="my-pat-token"
-    if [ -z "$ORG" ] || [ -z "$PAT" ]; then
-        TESTS_RUN=$((TESTS_RUN + 1))
-        TESTS_FAILED=$((TESTS_FAILED + 1))
-        echo -e "${RED}✗${NC} Should pass when both org and PAT are set"
-    else
+    ORG_CHECK_FAILED=false
+    PAT_CHECK_FAILED=false
+    
+    if [ -z "$ORG" ]; then
+        ORG_CHECK_FAILED=true
+    fi
+    if [ -z "$PAT" ]; then
+        PAT_CHECK_FAILED=true
+    fi
+    
+    if [ "$ORG_CHECK_FAILED" = false ] && [ "$PAT_CHECK_FAILED" = false ]; then
         TESTS_RUN=$((TESTS_RUN + 1))
         TESTS_PASSED=$((TESTS_PASSED + 1))
         echo -e "${GREEN}✓${NC} Should pass when both org and PAT are set"
+    else
+        TESTS_RUN=$((TESTS_RUN + 1))
+        TESTS_FAILED=$((TESTS_FAILED + 1))
+        echo -e "${RED}✗${NC} Should pass when both org and PAT are set"
     fi
 
-    # Test when org is empty (invalid)
+    # Test when org is empty (invalid) - should fail on org check
     ORG=""
     PAT="my-pat-token"
-    if [ -z "$ORG" ] || [ -z "$PAT" ]; then
+    if [ -z "$ORG" ]; then
         TESTS_RUN=$((TESTS_RUN + 1))
         TESTS_PASSED=$((TESTS_PASSED + 1))
         echo -e "${GREEN}✓${NC} Should fail when org is empty"
@@ -302,10 +312,10 @@ test_azdo_config_validation() {
         echo -e "${RED}✗${NC} Should fail when org is empty"
     fi
 
-    # Test when PAT is empty (invalid)
+    # Test when PAT is empty (invalid) - should fail on PAT check
     ORG="my-org"
     PAT=""
-    if [ -z "$ORG" ] || [ -z "$PAT" ]; then
+    if [ -z "$PAT" ]; then
         TESTS_RUN=$((TESTS_RUN + 1))
         TESTS_PASSED=$((TESTS_PASSED + 1))
         echo -e "${GREEN}✓${NC} Should fail when PAT is empty"
@@ -315,13 +325,13 @@ test_azdo_config_validation() {
         echo -e "${RED}✗${NC} Should fail when PAT is empty"
     fi
 
-    # Test when both are empty (invalid)
+    # Test when both are empty (invalid) - should fail on org check first
     ORG=""
     PAT=""
-    if [ -z "$ORG" ] || [ -z "$PAT" ]; then
+    if [ -z "$ORG" ]; then
         TESTS_RUN=$((TESTS_RUN + 1))
         TESTS_PASSED=$((TESTS_PASSED + 1))
-        echo -e "${GREEN}✓${NC} Should fail when both org and PAT are empty"
+        echo -e "${GREEN}✓${NC} Should fail when both org and PAT are empty (fails on org check)"
     else
         TESTS_RUN=$((TESTS_RUN + 1))
         TESTS_FAILED=$((TESTS_FAILED + 1))

action.yml

@@ -87,8 +87,12 @@ runs:
               if ${{ inputs.link-commits-to-pull-request }}; then
                 # make the call to main.js to do the linking
                 # Check to see if org/pat are set
-                if [ -z "${{ inputs.azure-devops-organization }}" ] || [ -z "${{ inputs.azure-devops-token }}" ]; then
-                  echo "::error title=Missing Azure DevOps Configuration::Azure DevOps organization and token are required when link-commits-to-pull-request is true"
+                if [ -z "${{ inputs.azure-devops-organization }}" ]; then
+                  echo "::error title=Missing Azure DevOps Configuration::Azure DevOps organization is required when link-commits-to-pull-request is true"
+                  exit 1
+                fi
+                if [ -z "${{ inputs.azure-devops-token }}" ]; then
+                  echo "::error title=Missing Azure DevOps Configuration::Azure DevOps token is required when link-commits-to-pull-request is true"
                   exit 1
                 fi
                 echo "Attempting to link work item ${WORKITEM} to pull request ${PULL_NUMBER}..."