From 894c0ce258bce7c61aa72b2a6b00c5408964da6f Mon Sep 17 00:00:00 2001
From: josibake <josibake@protonmail.com>
Date: Wed, 2 Aug 2023 12:56:22 +0200
Subject: [PATCH] tests: add receiving functional test

---
 test/functional/test_framework/test_node.py   |  4 +-
 test/functional/test_runner.py                |  1 +
 .../wallet_silentpayments_receiving.py        | 76 +++++++++++++++++++
 3 files changed, 79 insertions(+), 2 deletions(-)
 create mode 100755 test/functional/wallet_silentpayments_receiving.py

diff --git a/test/functional/test_framework/test_node.py b/test/functional/test_framework/test_node.py
index 67e0be52801a74..ea7021eac4318b 100755
--- a/test/functional/test_framework/test_node.py
+++ b/test/functional/test_framework/test_node.py
@@ -901,10 +901,10 @@ def __getattr__(self, name):
     def createwallet_passthrough(self, *args, **kwargs):
         return self.__getattr__("createwallet")(*args, **kwargs)
 
-    def createwallet(self, wallet_name, disable_private_keys=None, blank=None, passphrase='', avoid_reuse=None, descriptors=None, load_on_startup=None, external_signer=None):
+    def createwallet(self, wallet_name, disable_private_keys=None, blank=None, passphrase='', avoid_reuse=None, descriptors=None, load_on_startup=None, external_signer=None, silent_payment=None):
         if descriptors is None:
             descriptors = self.descriptors
-        return self.__getattr__('createwallet')(wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup, external_signer)
+        return self.__getattr__('createwallet')(wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup, external_signer, silent_payment)
 
     def importprivkey(self, privkey, label=None, rescan=None):
         wallet_info = self.getwalletinfo()
diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py
index 19443f44594c5e..541d5520ebbc06 100755
--- a/test/functional/test_runner.py
+++ b/test/functional/test_runner.py
@@ -206,6 +206,7 @@
     'mempool_reorg.py',
     'p2p_block_sync.py --v1transport',
     'p2p_block_sync.py --v2transport',
+    'wallet_silentpayments_receiving.py --descriptors',
     'wallet_createwallet.py --legacy-wallet',
     'wallet_createwallet.py --usecli',
     'wallet_createwallet.py --descriptors',
diff --git a/test/functional/wallet_silentpayments_receiving.py b/test/functional/wallet_silentpayments_receiving.py
new file mode 100755
index 00000000000000..9a38337f200e78
--- /dev/null
+++ b/test/functional/wallet_silentpayments_receiving.py
@@ -0,0 +1,76 @@
+#!/usr/bin/env python3
+
+from test_framework.test_framework import BitcoinTestFramework
+from test_framework.util import (
+    assert_approx,
+    assert_equal,
+    assert_raises_rpc_error,
+)
+
+
+class SilentPaymentsReceivingTest(BitcoinTestFramework):
+    def add_options(self, parser):
+        self.add_wallet_options(parser, legacy=False)
+
+    def set_test_params(self):
+        self.setup_clean_chain = True
+        self.num_nodes = 1
+
+    def skip_test_if_missing_module(self):
+        self.skip_if_no_wallet()
+        self.skip_if_no_sqlite()
+
+    def test_createwallet(self):
+        self.log.info("Check createwallet silent payments option")
+
+        self.nodes[0].createwallet(wallet_name="sp", silent_payment=True)
+        wallet = self.nodes[0].get_wallet_rpc("sp")
+        addr = wallet.getnewaddress(address_type="silent-payment")
+        assert addr.startswith("sp")
+        addr_again = wallet.getnewaddress(address_type="silent-payment")
+        assert_equal(addr, addr_again)
+
+        self.nodes[0].createwallet(wallet_name="non_sp", silent_payment=False)
+        wallet = self.nodes[0].get_wallet_rpc("non_sp")
+        assert_raises_rpc_error(-12, "Error: No silent-payment addresses available", wallet.getnewaddress, address_type="silent-payment")
+
+        if self.is_bdb_compiled():
+            assert_raises_rpc_error(-4, "Wallet with silent payments must also be a descriptor wallet", self.nodes[0].createwallet, wallet_name="legacy_sp", descriptors=False, silent_payment=True)
+
+            self.nodes[0].createwallet(wallet_name="legacy_sp", descriptors=False)
+            wallet = self.nodes[0].get_wallet_rpc("legacy_sp")
+            assert_raises_rpc_error(-12, "Error: No silent-payment addresses available", wallet.getnewaddress, address_type="silent-payment")
+
+    def test_basic(self):
+        self.log.info("Basic receive and send")
+
+        self.nodes[0].createwallet(wallet_name="basic", silent_payment=True)
+        wallet = self.nodes[0].get_wallet_rpc("basic")
+
+        addr = wallet.getnewaddress(address_type="silent-payment")
+        txid = self.def_wallet.sendtoaddress(addr, 10)
+        self.generate(self.nodes[0], 1)
+
+        assert_equal(wallet.getbalance(), 10)
+        wallet.gettransaction(txid)
+
+        self.log.info("Test self-transfer")
+        txid = wallet.send({addr: 5})
+        self.generate(self.nodes[0], 1)
+        assert_approx(wallet.getbalance(), 10, 0.0001)
+
+        wallet.sendall([self.def_wallet.getnewaddress()])
+        self.generate(self.nodes[0], 1)
+
+        assert_equal(wallet.getbalance(), 0)
+
+    def run_test(self):
+        self.def_wallet = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
+        self.generate(self.nodes[0], 101)
+
+        self.test_createwallet()
+        self.test_basic()
+
+
+if __name__ == '__main__':
+    SilentPaymentsReceivingTest().main()