Skip to content

Commit 2d12e85

Browse files
authored
Merge pull request #84 from jotaijs/kj/remove-wonka-improvements
feat: remove wonka as a peer dependency, subscribe directly to QueryObserver
2 parents fae6e21 + faeb54c commit 2d12e85

File tree

6 files changed

+5780
-4715
lines changed

6 files changed

+5780
-4715
lines changed

.github/workflows/cd.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@ jobs:
1010
runs-on: ubuntu-latest
1111
steps:
1212
- uses: actions/checkout@v3
13-
- uses: pnpm/action-setup@v2
13+
- uses: pnpm/action-setup@v4
1414
with:
15-
version: 8.2.0
15+
version: 9
1616
- uses: actions/setup-node@v3
1717
with:
1818
node-version: 18
1919
registry-url: 'https://registry.npmjs.org'
2020
cache: 'pnpm'
2121
cache-dependency-path: '**/pnpm-lock.yaml'
2222
- run: pnpm install --frozen-lockfile
23-
- run: npm test
24-
- run: npm run compile
25-
- run: npm publish
23+
- run: pnpm test
24+
- run: pnpm run compile
25+
- run: pnpm publish
2626
env:
2727
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ jobs:
99
runs-on: ubuntu-latest
1010
steps:
1111
- uses: actions/checkout@v3
12-
- uses: pnpm/action-setup@v2
12+
- uses: pnpm/action-setup@v4
1313
with:
14-
version: 8.2.0
14+
version: 9
1515
- uses: actions/setup-node@v3
1616
with:
1717
node-version: 18
1818
cache: 'pnpm'
1919
cache-dependency-path: '**/pnpm-lock.yaml'
2020
- run: pnpm install --frozen-lockfile
21-
- run: npm test
21+
- run: pnpm test

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ jotai-tanstack-query currently supports TanStack Query v5.
2727

2828
### Install
2929

30-
In addition to `jotai`, you have to install `jotai-tanstack-query`, `@tanstack/query-core` and `wonka` to use the extension.
30+
In addition to `jotai`, you have to install `jotai-tanstack-query` and `@tanstack/query-core` to use the extension.
3131

3232
```bash
33-
yarn add jotai-tanstack-query @tanstack/query-core wonka
33+
yarn add jotai-tanstack-query @tanstack/query-core
3434
```
3535

3636
### Incremental Adoption

package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,10 @@
8686
"typescript": "^5.2.2",
8787
"webpack": "^5.88.2",
8888
"webpack-cli": "^5.1.4",
89-
"webpack-dev-server": "^4.15.1",
90-
"wonka": "^6.3.4"
89+
"webpack-dev-server": "^4.15.1"
9190
},
9291
"peerDependencies": {
9392
"@tanstack/query-core": "*",
94-
"jotai": ">=2.0.0",
95-
"wonka": "^6.3.4"
93+
"jotai": ">=2.0.0"
9694
}
9795
}

0 commit comments

Comments
 (0)