Moved QueryContext action parameter initialization to more common place #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce so it will be available for every saule's call Enabled Fieldset filter for HandlesQuery case too
|
Thanks, this looks quite useful! Just to make sure, this is not a breaking change, correct? It seems like it is not, but I'd rather make sure. Also, do you think it is possible to write a test for this new functionality? I'd love not to break it accidentally in the future. |
|
@joukevandermaas sorry for so long answer. I missed your answer. so it didn't work for us so well, so we handled it in different way on top of If you want this change, i can add more unit tests and update PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jouke,
We had a case when WebApi action has
ObjectContextparameter and thenHandlesQueryattribute passes currentObjectContextvalue as paramter. So endpoint can consume\handle current context.I did two changes there:
I moved that code that initialize
ObjectContextin action's parameter to more common placeQueryContextUtilsso now it will be available to any action that needs it, and not only by action that hasHandlesQuery. So if endpoint withAllowsQuerywants to get current context for logging\other reasons, then it can get itI also added
Fieldsetinitialization toHandlesQueryso now it also can usefieldslogic too. As before that it would ignore it andObjectContextwon't parse actualFieldsetvalue