Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows and Linux line endings in VM #54

Closed
adelnoureddine opened this issue Jun 21, 2024 · 0 comments · Fixed by #80
Closed

Windows and Linux line endings in VM #54

adelnoureddine opened this issue Jun 21, 2024 · 0 comments · Fixed by #80
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@adelnoureddine
Copy link
Member

The VM monitoring in PowerJoular allows monitoring in a Linux guest under any host OS (including Windows).
However, line endings in Linux (LF) is \n while in Windows (CRLF) it is \r\n.

Get_Line in Ada removes line ending only of the platform it is running on.
For instance, in Linux, the function removes LF line endings.
When reading a file created in Windows (such as a Windows host and Linux guest), the function remove LF ending but not CRLF, thus keeping an additional character and fails in converting to Long_Float.

Currently, we created a new function Read_Watts that will manually copy the digits and dot and properly converts the data.
Ideally, we need to explore a better solution and to replace it with standard Ada functions.

@adelnoureddine adelnoureddine added the enhancement New feature or request label Jun 21, 2024
@adelnoureddine adelnoureddine self-assigned this Jun 21, 2024
@adelnoureddine adelnoureddine added this to the 1.1 milestone Nov 22, 2024
@adelnoureddine adelnoureddine linked a pull request Feb 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant