Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to ignore container memory setting #113

Open
lorenzobenvenuti opened this issue Dec 13, 2024 · 2 comments
Open

Allow to ignore container memory setting #113

lorenzobenvenuti opened this issue Dec 13, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@lorenzobenvenuti
Copy link
Contributor

lorenzobenvenuti commented Dec 13, 2024

Hi,

we're using Kubedock to run Quarkus tests in Openshift. Quarkus has a feature called "dev services" that allows to transparently start services as containers (it's based on Testcontainers); some of these containers are setting a value for "memory" (i.e. Docker --memory) and when this happens Kubedock overrides requests/limits settings using this value. However, in this way only requests are set and limits are inherited by the cluster LimitRange settings: in case the memory configured for the container is higher than the default limits value, the container won't start. In order to handle this scenario we'd like to have an option to ignore container settings and force Kubedock specific settings (either the default ones, specified as command line arguments, or those set using container labels).
I realize this is a pretty specific use case but I was wondering if other people could benefit from a similar option (something like --ignore-container-memory, default value == false). If you think it could be useful I can try to work on a PR.

Thanks!

lorenzo

@joyrex2001 joyrex2001 added the enhancement New feature or request label Dec 13, 2024
@joyrex2001
Copy link
Owner

Sounds useful, feel free to create a PR. I agree on the --ignore-container-memory suggestion.

@lorenzobenvenuti
Copy link
Contributor Author

PR here: #115

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants