From 8efc199864ae5833edbe64fba701d3e3dddb474a Mon Sep 17 00:00:00 2001
From: jpgouin <jgouin@vmware.com>
Date: Sun, 8 Jan 2023 14:54:33 +0100
Subject: [PATCH] change port exposition to 389 and 636

---
 Chart.yaml                  | 2 +-
 README.md                   | 6 +++---
 templates/statefullset.yaml | 4 ++--
 values.yaml                 | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Chart.yaml b/Chart.yaml
index 5b6a3c9..08d4df4 100644
--- a/Chart.yaml
+++ b/Chart.yaml
@@ -13,7 +13,7 @@ dependencies:
       - bitnami-common
     version: 1.x.x
 home: https://www.openldap.org
-version: 4.0.1
+version: 4.0.2
 appVersion: 2.6.3
 description: Community developed LDAP software
 icon: https://raw.githubusercontent.com/jp-gouin/helm-openldap/master/logo.png
diff --git a/README.md b/README.md
index 33cdad0..9a1be84 100755
--- a/README.md
+++ b/README.md
@@ -12,7 +12,7 @@ More detail on the container image can be found [here](https://github.com/bitnam
 There are some major changes between the Osixia version and the Bitnami version , ergo the major gap of the chart version.
 
 - Upgrade may not work fine between `3.x` and `4.x`
-- Ldap and Ldaps port are non privileged ports (`1389` and `1636`)
+- Ldap and Ldaps port are non privileged ports (`1389` and `1636`) internally but are exposed through `global.ldapPort` and `global.sslLdapPort` (389 and 636) 
 - Replication is now purely setup by configuration
 Extra schemas are loaded using `LDAP_EXTRA_SCHEMAS: "cosine,inetorgperson,nis,syncprov,serverid,csyncprov,rep,bsyncprov,brep"`
   - For now this list is harcoded and will be configurable in a future update.
@@ -64,8 +64,8 @@ Global parameters to configure the deployment of the application.
 | `global.ldapDomain`                     | Domain LDAP                                                                                                                         | `example.org`                 |
 | `global.adminPassword`                     | Administration password of Openldap                                                                                                                        | `Not@SecurePassw0rd`                 |
 | `global.configPassword`                     | Configuration password of Openldap                                                                                                                        | `Not@SecurePassw0rd`                 |
-| `global.ldapPort`                     | Ldap port                                                                                                                         | `1389`                 |
-| `global.sslLdapPort`                     | Ldaps port                                                                                                                         | `1636`                 |
+| `global.ldapPort`                     | Ldap port                                                                                                                         | `389`                 |
+| `global.sslLdapPort`                     | Ldaps port                                                                                                                         | `636`                 |
 
 ### Application parameters
 
diff --git a/templates/statefullset.yaml b/templates/statefullset.yaml
index ed07377..8778b20 100644
--- a/templates/statefullset.yaml
+++ b/templates/statefullset.yaml
@@ -140,9 +140,9 @@ spec:
           {{- end }}
           ports:
             - name: ldap-port
-              containerPort: {{ .Values.global.ldapPort }}
+              containerPort: 1389
             - name: ssl-ldap-port
-              containerPort: {{ .Values.global.sslLdapPort }}
+              containerPort: 1636
           {{- if .Values.livenessProbe.enabled }}
           livenessProbe:
             tcpSocket:
diff --git a/values.yaml b/values.yaml
index ed11011..d895c07 100644
--- a/values.yaml
+++ b/values.yaml
@@ -11,14 +11,14 @@ global:
   ## imagePullSecrets:
   ##   - myRegistryKeySecretName
   ##
-  imagePullSecrets: [""]
+  #imagePullSecrets: [""]
   storageClass: ""
   ldapDomain: "example.org"
   ## Default Passwords to use, stored as a secret. Not used if existingSecret is set.
   adminPassword:  Not@SecurePassw0rd
   configPassword: Not@SecurePassw0rd
-  ldapPort: 1389
-  sslLdapPort: 1636
+  ldapPort: 389
+  sslLdapPort: 636
 
 ## @section Common parameters