add command to openldap container #194
Conversation
… try to init certain stuff - more detail: jp-gouin#148 (comment)
|
potentially fixes #148 the list of env vars that are removed is non exhaustive, maybe more need to be added, these are just the ones that were causing problems in my setup |
|
Hi @davidfrickert , |
templates/statefulset.yaml
Outdated
| @@ -182,6 +182,22 @@ spec: | |||
| {{- if .Values.containerSecurityContext.enabled }} | |||
| securityContext: {{- omit .Values.containerSecurityContext "enabled" | toYaml | nindent 12 }} | |||
| {{- end }} | |||
| command: | |||
There was a problem hiding this comment.
This one conflicts with recently restored command on L177.
To not overwrite user supplied .Values.command please move above L176 or incorporate condition block.
templates/statefulset.yaml
Outdated
| export LDAP_SKIP_DEFAULT_TREE=yes | ||
| fi | ||
| /opt/bitnami/scripts/openldap/entrypoint.sh /opt/bitnami/scripts/openldap/run.sh |
There was a problem hiding this comment.
This is bitnami-specific and fail on custom container.
Either we postulate that only bitnami/openldap is supported, or check that things in place before calls.
There was a problem hiding this comment.
Also, the /opt/bitnami/scripts/openldap/run.sh is actually default CMD (args in k8s manifest), so highly recommend change:
- fom
/opt/bitnami/scripts/openldap/entrypoint.sh /opt/bitnami/scripts/openldap/run.sh - to
exec /opt/bitnami/scripts/openldap/entrypoint.sh
That will avoid overwriting default or user-supplied args.
There was a problem hiding this comment.
hey, just came back from vacation will try to resolve these issues this or next week
There was a problem hiding this comment.
Also, the
/opt/bitnami/scripts/openldap/run.shis actually defaultCMD(argsin k8s manifest), so highly recommend change:* fom `/opt/bitnami/scripts/openldap/entrypoint.sh /opt/bitnami/scripts/openldap/run.sh` * to `exec /opt/bitnami/scripts/openldap/entrypoint.sh`That will avoid overwriting default or user-supplied args.
hmm exec /opt/bitnami/scripts/openldap/entrypoint.sh does not seem to work
--> /opt/bitnami/scripts/openldap/entrypoint.sh: line 14: $1: unbound variable
(from latest commit on this PR)
There was a problem hiding this comment.
The help exec states that ARGUMENTS become the arguments to COMMAND.
Anyway, try to pass args explicitly:
exec "/opt/bitnami/scripts/openldap/entrypoint.sh" "$@"
Also, ensure that args is not set to empty list -- this will overwrite original image cmd (check with helm template -f values.yaml helm-openldap/openldap-stack-ha --show-only templates/statefulset.yaml)
…-openldap-init-issue
…idfrickert/helm-openldap into feat/fix-openldap-init-issue
this command ensures non-first openldap containers dont try to init already initialized cluster-wide resources, such as the root DN or ppolicy module.
What this PR does / why we need it:
Pre-submission checklist: