Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication sequence freezing upon opening the browser #588

Closed
gitRaiku opened this issue Feb 21, 2025 · 2 comments
Closed

Authentication sequence freezing upon opening the browser #588

gitRaiku opened this issue Feb 21, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@gitRaiku
Copy link
Contributor

Describe the bug
When first logging in with psst, the code path runs through

let (auth_url, pkce_verifier) = oauth::generate_auth_url(8888);
if open::that(&auth_url).is_err() {
    data.error_alert("Failed to open browser");
    return;
}

in psst-gui/src/ui/preferences.rs.

Running open::that() opens firefox, halting execution until firefox is closed, blocking the creation of the thread, blocking with it the creation of the oauth socket.

To Reproduce
Run psst-gui for the first time.

Expected behavior
Have the socket be created while firefox is running.

Environment

  • OS: Arch linux 6.13.2
  • Firefox: 135.0
@gitRaiku gitRaiku added the bug Something isn't working label Feb 21, 2025
@gitRaiku
Copy link
Contributor Author

Pull request #589 tries to alleviate this issue.

@jacksongoode
Copy link
Collaborator

Closed in latest commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants