From bed4882ea5f75b0d0aac5d76513c91d108f198a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Paulo?= Date: Tue, 25 Feb 2025 08:04:43 -0300 Subject: [PATCH 1/2] [fix] /pos command This PR fixes /pos command show to all --- data/scripts/talkactions/gm/position.lua | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/data/scripts/talkactions/gm/position.lua b/data/scripts/talkactions/gm/position.lua index dc95552d..0bc36a8a 100644 --- a/data/scripts/talkactions/gm/position.lua +++ b/data/scripts/talkactions/gm/position.lua @@ -7,25 +7,28 @@ function position.onSay(player, words, param) if param == "" then local pos = player:getPosition() player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "Your current position is: " .. pos.x .. ", " .. pos.y .. ", " .. pos.z .. ".") - return + return true end local teleportPosition = param:toPosition() if not teleportPosition then player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "Invalid position format. Use one of the following formats: \n/pos {x = ..., y = ..., z = ...}\n/pos Position(..., ..., ...)\n/pos x, y, z.") - return + return true end local tile = Tile(teleportPosition) if not tile then player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "Invalid tile or position. Send a valid position.") - return + return true end player:teleportTo(teleportPosition) if not player:isInGhostMode() then teleportPosition:sendMagicEffect(CONST_ME_TELEPORT) + return true end + + return true end position:separator(" ") From f699ad9496215a430a9c362aa0f22bc5978fdb46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Paulo?= Date: Tue, 25 Feb 2025 08:06:32 -0300 Subject: [PATCH 2/2] * delete templates --- .github/ISSUE_TEMPLATE/bug.yaml | 65 ----------------------------- .github/ISSUE_TEMPLATE/request.yaml | 48 --------------------- .github/PULL_REQUEST_TEMPLATE.md | 47 --------------------- 3 files changed, 160 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/bug.yaml delete mode 100644 .github/ISSUE_TEMPLATE/request.yaml delete mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE/bug.yaml b/.github/ISSUE_TEMPLATE/bug.yaml deleted file mode 100644 index 9f96d988..00000000 --- a/.github/ISSUE_TEMPLATE/bug.yaml +++ /dev/null @@ -1,65 +0,0 @@ -name: Report a problem/bug -description: Any issues that you have found while using the server -labels: ["Type: Bug"] -body: - - type: markdown - attributes: - value: | - Thanks for taking the time to fill out this issue! - - - type: dropdown - id: priority - attributes: - label: Priority - description: How critical is this? - options: - - Low - - Medium - - High - - Critical - validations: - required: true - - - type: checkboxes - id: area - attributes: - label: Area - description: Where is the problem? - options: - - label: Datapack - - label: Source - - label: Map - - label: Other - validations: - required: true - - - type: textarea - id: what-happened - attributes: - label: What happened? - description: Describe your problem/bug and add screenshots, logs or anything that can help verifying the bug - placeholder: Tell us what you see! - value: "A bug happened!" - validations: - required: true - - - type: dropdown - id: os - attributes: - label: What OS are you seeing the problem on? - multiple: true - options: - - Linux - - Windows - - MacOS - validations: - required: true - - - type: checkboxes - id: terms - attributes: - label: Code of Conduct - description: By submitting this issue, you agree to follow our [Code of Conduct](https://github.com/jprzimba/crystalserver/blob/main/markdowns/CODE_OF_CONDUCT.md) - options: - - label: I agree to follow this project's Code of Conduct - required: true diff --git a/.github/ISSUE_TEMPLATE/request.yaml b/.github/ISSUE_TEMPLATE/request.yaml deleted file mode 100644 index d32dbcfd..00000000 --- a/.github/ISSUE_TEMPLATE/request.yaml +++ /dev/null @@ -1,48 +0,0 @@ -name: Request -description: Any request -body: - - type: markdown - attributes: - value: | - Thanks for taking the time to fill out this issue! - - - type: dropdown - id: priority - attributes: - label: Priority - description: How critical is this? - options: - - Missing Content - - Enhancement - validations: - required: true - - - type: checkboxes - id: area - attributes: - label: Area - description: Where is the problem? - options: - - label: Datapack - - label: Source - - label: Map - - label: Other - validations: - required: true - - - type: textarea - id: missing-content - attributes: - label: What is missing? - description: Map, sprite, script, quest, teleport, monster, etc. Attach screenshots, logs, etc, anything that can helps us - validations: - required: true - - - type: checkboxes - id: terms - attributes: - label: Code of Conduct - description: By submitting this issue, you agree to follow our [Code of Conduct](https://github.com/jprzimba/crystalserver/blob/main/markdowns/CODE_OF_CONDUCT.md) - options: - - label: I agree to follow this project's Code of Conduct - required: true diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md deleted file mode 100644 index 5890cad7..00000000 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ /dev/null @@ -1,47 +0,0 @@ - -# Description - -Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. - -## Behaviour -### **Actual** - -Do this and that doesn't happens - -### **Expected** - -Do this and that happens - -### Fixes #issuenumber - -## Type of change - -Please delete options that are not relevant. - - - [ ] Bug fix (non-breaking change which fixes an issue) - - [ ] New feature (non-breaking change which adds functionality) - - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - - [ ] This change requires a documentation update - -## How Has This Been Tested - -Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - - - [ ] Test A - - [ ] Test B - -**Test Configuration**: - - - Server Version: - - Client: - - Operating System: - -## Checklist - - - [ ] My code follows the style guidelines of this project - - [ ] I have performed a self-review of my own code - - [ ] I checked the PR checks reports - - [ ] I have commented my code, particularly in hard-to-understand areas - - [ ] I have made corresponding changes to the documentation - - [ ] My changes generate no new warnings - - [ ] I have added tests that prove my fix is effective or that my feature works