Skip to content

Commit 6aa56a7

Browse files
committed
Remove DOMException dev dependency
Node.js v18+ has one built-in, which suffices for our purpose of running web platform tests.
1 parent 6c6fb17 commit 6aa56a7

File tree

4 files changed

+2
-17
lines changed

4 files changed

+2
-17
lines changed

package-lock.json

Lines changed: 0 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"@domenic/eslint-config": "^3.0.0",
2020
"benchmark": "^2.1.4",
2121
"c8": "^8.0.1",
22-
"domexception": "^4.0.0",
2322
"esbuild": "^0.19.5",
2423
"eslint": "^8.53.0",
2524
"webidl2js": "^17.1.0"

test/testharness.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ module.exports = {
3434
},
3535

3636
assert_throws_js(errorConstructor, func) {
37-
// Don't bother testing the errorConstructor since that brings in tricky realm issues.
38-
assert.throws(func);
37+
// Don't pass errorConstructor itself since that brings in tricky realm issues.
38+
assert.throws(func, errorConstructor.name);
3939
},
4040

4141
assert_unreached() {

test/web-platform.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const path = require("path");
44
const fs = require("fs");
55
const vm = require("vm");
66
const assert = require("assert");
7-
const DOMException = require("domexception");
87
const { directlyRunnableTests, resourceDependentTests } = require("../scripts/get-latest-platform-tests.js");
98
const testharness = require("./testharness.js");
109

0 commit comments

Comments
 (0)