{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":479467373,"defaultBranch":"main","name":"docker-wagtail-develop","ownerLogin":"jsma","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-04-08T16:41:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/24574?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1699742893.0","currentOid":""},"activityList":{"items":[{"before":"4a091c8cfc50fa30943398c62665252aa2c82a73","after":"41c228355a3136da0bcda020f4820d2805214d2c","ref":"refs/heads/modernize-docker-compose","pushedAt":"2023-11-13T16:44:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"},"commit":{"message":"Fixed invalid Markdown in bash script 😝","shortMessageHtmlLink":"Fixed invalid Markdown in bash script 😝"}},{"before":"01ad11ce7239e1f95bfdc1fa620ea3b5e441974b","after":"4a091c8cfc50fa30943398c62665252aa2c82a73","ref":"refs/heads/modernize-docker-compose","pushedAt":"2023-11-13T15:52:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"},"commit":{"message":"Fixed path to Dockerfile for Github worfklow","shortMessageHtmlLink":"Fixed path to Dockerfile for Github worfklow"}},{"before":"7b87fc5697399ad507fd44968eddb8de162793a0","after":"01ad11ce7239e1f95bfdc1fa620ea3b5e441974b","ref":"refs/heads/modernize-docker-compose","pushedAt":"2023-11-13T01:33:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"},"commit":{"message":"Updates and optimizations\n\nRenames docker-compose.yml => compose.yaml which is the new preferred name going forward\nMoves Dockerfiles to subdirectory, ensuring the filenames end with Dockerfile (for syntax highlighting in IDEs)\nRenamed the `web` service to `app`, since this is typical for Docker examples and is also what bakerydemo uses\nVarious tricks and tips to optimize the build cache to speed up subsequent builds\n\nThe new Dockerfile was partially based on the output of `docker init`, which includes some best practices:\n* create non-root users to run the applications\n* use bind-mounts for pip & npm installs (this means that when adding a new requirement, it will only download the new package and install everything else from the cache)\n\nNOTE: the wagtail and libs directories are no longer COPY'd into the container for doing a `pip install`, but installing wagtail and django-modelcluster creates .egg-info directories, so the bind mounts need write access.\n\nAdded custom ignore files for each Dockerfile to restrict the build context to the absolute minimum\n\nAdded a custom requirements file to avoid relying on bakerydemo's requirements which results in duplicate installs.\nThe previous setup was installing bakerydemo requirements, which installed wagtail, django-modelcluster, and Willow, and then a few steps later, reinstalling these packages from the local sources. Now they are only installed once.\n\nThe CMDs for both `app` and `frontend` are now wrapped with `dumb-init` (node is not designed to run as PID 1) which handles killing the processes. Previously attempting the Ctrl-C the running containers would hang waiting for `npm` to give up the ghost, now it exits immediately.","shortMessageHtmlLink":"Updates and optimizations"}},{"before":"db8914ca97f9946ee2ebe869189fdff6523e94cf","after":"7b87fc5697399ad507fd44968eddb8de162793a0","ref":"refs/heads/modernize-docker-compose","pushedAt":"2023-11-11T22:55:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"},"commit":{"message":"Modernize `docker-compose.yml`\n\n* Move database connection parameters to an environment file to avoid duplication\n* Update to modern command `docker compose` vs `docker-compose`\n* Remove the version number from the file since this is ignored by docker and causes IDEs to attempt to validate\n* Removed mount of `node_modules` volume in `web` container since the `web` container does not have `node` installed\n* Removed `:delegated,rw` since this was the incorrect option (it meant that the container had the authoritative view of the files, leading to long delays in synchronizing with the host which caused issues when trying to detect changes for migrations, etc.), and is no longer necessary in modern docker\n* Added health checks for containers to avoid warnings/errors\n* Updated base image to python:3.9-bullseye to at least match the version used in `bakerydemo`'s `docker-compose.yml`\n* Updated base image to postgres:14.1 to match `bakerydemo`'s `docker-compose.yml`","shortMessageHtmlLink":"Modernize <code>docker-compose.yml</code>"}},{"before":"9479945080321c9813597de4cd4817a2f319ebde","after":"6e0397297924d94bff43177361a42db969063209","ref":"refs/heads/main","pushedAt":"2023-11-11T22:50:21.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"},"commit":{"message":"Upgrade to node version 20","shortMessageHtmlLink":"Upgrade to node version 20"}},{"before":"774fb9ac48ee51129d64f5f3b1b69215534e5a0c","after":null,"ref":"refs/heads/fix-56","pushedAt":"2023-11-11T22:48:13.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"}},{"before":"aa5716dd477d15114481f127e5c91e5f2bb72c0f","after":null,"ref":"refs/heads/fix-68","pushedAt":"2023-11-11T22:41:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"}},{"before":"fec9316ec0cfe27e9d06f0fda4cc1e16475b90ca","after":"db8914ca97f9946ee2ebe869189fdff6523e94cf","ref":"refs/heads/modernize-docker-compose","pushedAt":"2023-11-11T05:50:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"},"commit":{"message":"Modernize `docker-compose.yml`\n\n* Move database connection parameters to an environment file to avoid duplication\n* Update to modern command `docker compose` vs `docker-compose`\n* Remove the version number from the file since this is ignored by docker and causes IDEs to attempt to validate\n* Removed mount of `node_modules` volume in `web` container since the `web` container does not have `node` installed\n* Removed `:delegated,rw` since this was the incorrect option (it meant that the container had the authoritative view of the files, leading to long delays in synchronizing with the host which caused issues when trying to detect changes for migrations, etc.), and is no longer necessary in modern docker\n* Added health checks for containers to avoid warnings/errors\n* Updated base image to python:3.9-bullseye to at least match the version used in `bakerydemo`'s `docker-compose.yml`\n* Updated base image to postgres:14.1 to match `bakerydemo`'s `docker-compose.yml`","shortMessageHtmlLink":"Modernize <code>docker-compose.yml</code>"}},{"before":null,"after":"fec9316ec0cfe27e9d06f0fda4cc1e16475b90ca","ref":"refs/heads/modernize-docker-compose","pushedAt":"2023-11-11T02:09:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"},"commit":{"message":"Modernize `docker-compose.yml`\n\n* Move database connection parameters to an environment file to avoid duplication\n* Update to modern command `docker compose` vs `docker-compose`\n* Remove the version number from the file since this is ignored by docker and causes IDEs to attempt to validate\n* Removed mount of `node_modules` volume in `web` container since the `web` container does not have `node` installed\n* Removed `:delegated,rw` since this was the incorrect option (it meant that the container had the authoritative view of the files, leading to long delays in synchronizing with the host which caused issues when trying to detect changes for migrations, etc.), and is no longer necessary in modern docker\n* Added health checks for containers to avoid warnings/errors\n* Updated base image to python:3.9-bullseye to at least match the version used in `bakerydemo`'s `docker-compose.yml`\n* Updated base image to postgres:14.1 to match `bakerydemo`'s `docker-compose.yml`","shortMessageHtmlLink":"Modernize <code>docker-compose.yml</code>"}},{"before":null,"after":"aa5716dd477d15114481f127e5c91e5f2bb72c0f","ref":"refs/heads/fix-68","pushedAt":"2023-11-10T07:51:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"},"commit":{"message":"Removed `bakerydemo-settings-local.py.example`\n\nThis file never worked, it caused a circular import loop since it attempts to `from bakerydemo.settings.dev import *` but the dev settings does:\n\n```python\ntry:\n    from .local import *  # noqa\nexcept ImportError:\n    pass\n```\n\nFixed the `setup.sh` script to set the correct settings module environment variable\n\nFixes #68","shortMessageHtmlLink":"Removed <code>bakerydemo-settings-local.py.example</code>"}},{"before":null,"after":"774fb9ac48ee51129d64f5f3b1b69215534e5a0c","ref":"refs/heads/fix-56","pushedAt":"2023-11-10T07:42:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"},"commit":{"message":"Remove uninterpreted environment variable from `docker-compose.yml`\n\nThis caused a spurious warning when running `docker compose` commands because `$PYTHONPATH` is not defined on the docker _host_ and docker attempted to interpret it as if it were any other environment variable e.g. `$DB_USER`, etc.\n\nAll it accomplished was to add a non-existent directory to the path:\n\n```bash\ndocker compose run web bash\nroot@2bc54a69fd5c:/code/bakerydemo# echo $PYTHONPATH\n/code/wagtail:/code/bakerydemo:$PYTHONPATH\n\nroot@2bc54a69fd5c:/code/bakerydemo# python -c \"import sys; print('\\n'.join(sys.path))\"\n\n/code/wagtail\n/code/bakerydemo\n/code/bakerydemo/$PYTHONPATH\n/usr/local/lib/python38.zip\n/usr/local/lib/python3.8\n/usr/local/lib/python3.8/lib-dynload\n/usr/local/lib/python3.8/site-packages\n/code/willow\n```\n\nFixes #56","shortMessageHtmlLink":"Remove uninterpreted environment variable from <code>docker-compose.yml</code>"}},{"before":"e6ee6816e2ec888cc2df3bddbbe49bbaf94bf258","after":"9479945080321c9813597de4cd4817a2f319ebde","ref":"refs/heads/main","pushedAt":"2023-11-10T07:41:14.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"jsma","name":"John-Scott Atlakson","path":"/jsma","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24574?s=80&v=4"},"commit":{"message":"Update README.md (#65)\n\nInclude cross-reference to Wagtail's Vagrant development setup. Useful for those that get stuck with / cannot use Docker.","shortMessageHtmlLink":"Update README.md (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1914282702\" data-permission-text=\"Title is private\" data-url=\"https://github.com/wagtail/docker-wagtail-develop/issues/65\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/wagtail/docker-wagtail-develop/pull/65/hovercard\" href=\"https://github.com/wagtail/docker-wagtail-develop/pull/65\">wagtail#65</a>)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMS0xM1QxNjo0NDo1Ny4wMDAwMDBazwAAAAOuBrPr","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMS0xMFQwNzo0MToxNC4wMDAwMDBazwAAAAOr-YDm"}},"title":"Activity · jsma/docker-wagtail-develop"}