Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please bring back theme called "full" #46

Closed
levino opened this issue Dec 1, 2023 · 2 comments
Closed

please bring back theme called "full" #46

levino opened this issue Dec 1, 2023 · 2 comments
Labels
theme

Comments

@levino
Copy link
Collaborator

levino commented Dec 1, 2023 

          please bring back theme called "full"

Originally posted by @sachsgiri in #36 (comment)
@levino
Copy link
Collaborator Author

levino commented Dec 1, 2023

NPM https://www.npmjs.com/package/jsonresume-theme-full
github https://github.com/jackkeller/jsonresume-theme-full#readme

The problem is that the theme is using handlebars@2 which is deprecated and has proven security vulnerabilities. Source code needs to be updated, then we might be able to bring it back.

Do you think you could make a PR for jsonresume-theme-full to update the handlebars dependency @sachsgiri?

@levino levino added the theme label Dec 1, 2023
@thomasdavis
Copy link
Member

fixed in #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasdavis @levino