parse Edm.Decimal correctly in the postgres driver result

Author: bjrmatos

lib/main.js

@@ -1,5 +1,8 @@
 const Promise = require('bluebird')
 const pg = require('pg-promise')({promiseLib: Promise})
+// how to configure type parsing per instance
+// https://github.com/brianc/node-postgres/issues/1838
+const TypeOverrides = require('pg/lib/type-overrides')
 const Store = require('jsreport-sql-store')
 
 module.exports = function (reporter, definition) {
@@ -8,6 +11,22 @@ module.exports = function (reporter, definition) {
     return
   }
 
+  const customTypes = new TypeOverrides()
+
+  // postgres does not parse numeric(d,d) type by default, we
+  // need to add the parsing manually, so we register a custom types collection
+  // to don't alter the global behaviour of the queries,
+  // we just care about our database driver instance and don't want to change the way the
+  // driver works by default in all cases/instances.
+  //
+  // 1700 is the id for numeric type
+  // https://github.com/vitaly-t/pg-promise/issues/214
+  customTypes.setTypeParser(1700, (value) => {
+    return parseFloat(value)
+  })
+
+  definition.options.types = customTypes
+
   const db = pg(definition.options)
 
   function executeQuery (a, opts = {}) {

package-lock.json

@@ -22,7 +22,7 @@
   },
   "devDependencies": {
     "eslint-config-standard": "11.0.0",
-    "jsreport-core": "2.7.0",
+    "jsreport-core": "2.7.2",
     "mocha": "5.2.0",
     "should": "13.2.3",
     "standard": "11.0.1"

package.json

@@ -15,6 +15,16 @@ describe('common store tests', () => {
       'user': 'postgres',
       'password': 'password'
     })).use(() => {
+      instance.documentStore.registerEntityType('InstanceCustomType', {
+        name: { type: 'Edm.String', publicKey: true },
+        score: { type: 'Edm.Decimal' }
+      })
+
+      instance.documentStore.registerEntitySet('testingInstances', {
+        entityType: 'jsreport.InstanceCustomType',
+        splitIntoDirectories: true
+      })
+
       jsreport.tests.documentStore().init(() => instance.documentStore)
     })
 
@@ -37,4 +47,17 @@ describe('common store tests', () => {
   afterEach(() => reporter.close())
 
   jsreport.tests.documentStore()(() => reporter.documentStore)
+
+  it('should correctly parse decimal type from db', async () => {
+    await reporter.documentStore.collection('testingInstances').insert({
+      name: 'test',
+      score: 1.5
+    })
+
+    const entity = await reporter.documentStore.collection('testingInstances').findOne({
+      name: 'test'
+    })
+
+    entity.score.should.be.eql(1.5)
+  })
 })