From 5cf3d588c00d58c220f638998bb5c0653cd6b701 Mon Sep 17 00:00:00 2001 From: Justin Harris Date: Mon, 1 Dec 2025 12:33:07 -0500 Subject: [PATCH] [Rust] Change some `if let Some`s that do not use the value --- rust/optify/src/provider/provider_impl.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/rust/optify/src/provider/provider_impl.rs b/rust/optify/src/provider/provider_impl.rs index 963c4d73..fd5fb797 100644 --- a/rust/optify/src/provider/provider_impl.rs +++ b/rust/optify/src/provider/provider_impl.rs @@ -68,7 +68,7 @@ impl OptionsProvider { cache_options: Option<&CacheOptions>, preferences: Option<&GetOptionsPreferences>, ) -> Result { - if let Some(_cache_options) = cache_options { + if cache_options.is_some() { match self.get_entire_config_from_cache(feature_names, preferences) { Ok(Some(config)) => return Ok(config), Ok(None) => (), @@ -114,7 +114,7 @@ impl OptionsProvider { } } - if let Some(_cache_options) = cache_options { + if cache_options.is_some() { let cache_key = feature_names.to_owned(); self.entire_config_cache .write() @@ -404,9 +404,9 @@ impl OptionsRegistry for OptionsProvider { ) -> Result, String> { let mut skip_feature_name_conversion = false; let mut constraints = None; - if let Some(_preferences) = preferences { - skip_feature_name_conversion = _preferences.skip_feature_name_conversion; - constraints = _preferences.constraints.as_ref(); + if let Some(preferences) = preferences { + skip_feature_name_conversion = preferences.skip_feature_name_conversion; + constraints = preferences.constraints.as_ref(); } let mut result = Vec::new(); @@ -448,7 +448,7 @@ impl OptionsRegistry for OptionsProvider { cache_options: Option<&CacheOptions>, preferences: Option<&GetOptionsPreferences>, ) -> Result { - if let Some(_cache_options) = cache_options { + if cache_options.is_some() { match self.get_options_from_cache(key, feature_names, cache_options, preferences) { Ok(Some(options)) => return Ok(options), Ok(None) => (),